-
Notifications
You must be signed in to change notification settings - Fork 145
Topics: add Simplicity #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Topics: add Simplicity #446
Conversation
|
Concept ACK. Thanks! I'd prefer a more detailed excerpt/detailed_summary, perhaps including information like:
In short, text that convinces me that this is worth considering (but without hiding any likely downsides). @michaelfolkson Let me know if the anchor linking instructions in harding#15 (comment) are insufficient to address the links on this PR as well. |
|
Concept ACK as well! I could have used this link last week as well |
|
Thanks for this @michaelfolkson . Will review once you've addressed @harding's review comments. |
|
@michaelfolkson - are you planning to update this PR? |
|
Yes I will work on this after I've finished this month's transcripts section. Thanks for the reminder and apologies for delay. |
|
Pushed an additional commit that addresses most if not all of @harding suggestions and adds the correct links to prior newsletters. [edit: The content is ready to be reviewed (I think) but checks are failing so evidently I still need to address some formatting issues.] |
harding
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is an improvement, thanks! Left some comments. Looks like tests are failing because the intro paragraph is over 500 characters.
|
@michaelfolkson - quick reminder that there are some outstanding review comments on this and the build is failing because the intro paragraph is too long. Are you planning to work on this again? |
|
@jnewbery: Yes I'll work on this Thursday and push update then (after Bitcoin Core PR review club) if that is ok. |
50dec48 to
0e7e2c2
Compare
|
Pushed latest changes but builds are failing (I haven't built locally yet). Will investigate.
Is the limit for the intro paragraph 500 characters including spaces or excluding spaces? I think it is 500 characters including spaces... |
3b966f4 to
9fec4bb
Compare
Including spaces (but not the indentation). |
9fec4bb to
e5546b8
Compare
|
Checks are passing now. It didn't like |
Yes, you need to use the shortname of the topic page, or the title if there's no shortname. The title in this case is SIGHASH_NOINPUT. |
Topics: suggested edits to Simplicity topic
|
Merged in some more @harding suggested edits. I think this is at final review stage (or at least very close to it). |
|
A reminder that this is ready to be reviewed. Latest @harding edits are merged. |
|
ACK 931c5c1 If additional changes are requested by other people, I think maybe the simplicity.pdf link should be moved from the |
At the very least I need to add hashtags (I couldn't find the hashtags to link to specific sections of previous newsletters). There may be other stuff I've missed too.
However, I think we need a Simplicity topics page as it has cropped up in the newsletter a number of times now and so hopefully this is at least a start.