Field report: CardCoins rbf and batching #582
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CardCoins
reviewed
May 31, 2021
jnewbery
reviewed
Jun 1, 2021
Contributor
jnewbery
left a comment
jnewbery
left a comment
There was a problem hiding this comment.
Looks good. I pushed a commit with various changes. Let me know what you think.
Contributor
Author
|
Resolved all comments except: #582 (comment) @CardCoins do you have an opinion on how youd like to address this if at all? |
|
@bitschmidty Sorry just getting back from the conference, will have a close look tomorrow. Thanks all for the reviews. |
Contributor
Author
|
Thanks @CardCoins ! We plan to publish this post on June 16, along with our weekly newsletter. One more thing needed to wrap up this summary post would be the url of the 'Mempool's Dark Reorg Forest', when published. |
CardCoins
reviewed
Jun 9, 2021
Contributor
|
The new intro looks good, but it makes some of the text in the later paragraph redundant. I've pushed a commit that makes a few changes to reduce that redundancy. |
jnewbery
force-pushed
the
2021-06-field-report-rbf-batching
branch
from
f4fb8f1 to
8966f6d
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.