-
Notifications
You must be signed in to change notification settings - Fork 146
Newsletters: add #19 (2018-10-30) #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
No problem! Thanks as ever for writing it. I'll review it this evening. @moneyball - are you still at work and feel like reviewing? |
|
I made a few minor changes - take a look at them to make sure they're correct. I also read the entire newsletter and tested it locally. Well written! I do not have the technical depth and history to confirm all of the info in notable merges, but it all seems to make sense to me. tACK |
|
|
||
| - **Overt ASICBoost support for S9 miners:** support for this | ||
| efficiency-improving feature was announced by both [Bitmain][bitmain oab] | ||
| and [Braiins][braiins oab] this week. Both covert and overt ASICBoost |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this sentence could be clearer. I've made an attempt in my commit, but I'm not sure if it's any better. Let me know what you think.
We could also link directly to one of the following:
the ASICboost paper : http://www.math.rwth-aachen.de/~Timo.Hanke/AsicBoostWhitepaperrev5.pdf
stack exchange answer: https://bitcoin.stackexchange.com/questions/43579/how-does-asicboost-work
blog post by ASICboost author: https://bitslog.wordpress.com/2017/04/10/the-relation-between-segwit-and-asicboost-covert-and-overt/
|
@harding - I've pushed a suggested change in a commit. Feel free to squash it or drop it. Otherwise looks great. ACK fbb4746 @moneyball - your changes look good. Thanks. |
9df0fde to
9f809c0
Compare
|
Thanks both of you! @jnewbery your description of ASICBoost was much better than mine! I made a final small tweak to the introduction in and rephrased the text about Pierre's blog posts given that the residency program had more days than he has posts. For review, those changes are in commit d91a415 on a preservation of the full branch. Otherwise, I've squashed on this branch. Thanks again! |
|
Thanks Dave. I've pushed one final change. The residency was over 5 days, but the guest speakers gave their presentations on Mon-Thurs (Friday was left for residents to finish their projects and give demos). I've reworded the section to make it clear that Pierre's articles summarize all of the presentations. Let me know what you think. |
|
ACK 5b7f65e . Thanks! |
5b7f65e to
b4bb58b
Compare
|
squashed and merged |
* newsletter-271: translate into Chinese * Apply suggestions from code review Co-authored-by: editor-Ajian <34365188+editor-Ajian@users.noreply.github.com> * fix style * Update _posts/zh/newsletters/2023-10-04-newsletter.md Co-authored-by: freeyao <johnyao1526@gmail.com> --------- Co-authored-by: Zhiwei(Jeffrey) Hu <huzhiwei@outlook.com> Co-authored-by: editor-Ajian <34365188+editor-Ajian@users.noreply.github.com> Co-authored-by: freeyao <johnyao1526@gmail.com>
* newsletter-271: translate into Chinese * Apply suggestions from code review Co-authored-by: editor-Ajian <34365188+editor-Ajian@users.noreply.github.com> * fix style * Update _posts/zh/newsletters/2023-10-04-newsletter.md Co-authored-by: freeyao <johnyao1526@gmail.com> --------- Co-authored-by: Zhiwei(Jeffrey) Hu <huzhiwei@outlook.com> Co-authored-by: editor-Ajian <34365188+editor-Ajian@users.noreply.github.com> Co-authored-by: freeyao <johnyao1526@gmail.com>
I'm terribly, terribly sorry this is so late. :-(
Otherwise, hopefully it's ok. I won't be around this evening to address feedback, but I will check first thing tomorrow morning (around 06:00 EDT) and make any requested changes then.