Skip to content

Conversation

@harding
Copy link
Collaborator

@harding harding commented Oct 29, 2018

I'm terribly, terribly sorry this is so late. :-(

Otherwise, hopefully it's ok. I won't be around this evening to address feedback, but I will check first thing tomorrow morning (around 06:00 EDT) and make any requested changes then.

@jnewbery
Copy link
Contributor

I'm terribly, terribly sorry this is so late. :-(

No problem! Thanks as ever for writing it. I'll review it this evening.

@moneyball - are you still at work and feel like reviewing?

@moneyball
Copy link
Contributor

I made a few minor changes - take a look at them to make sure they're correct.

I also read the entire newsletter and tested it locally. Well written! I do not have the technical depth and history to confirm all of the info in notable merges, but it all seems to make sense to me.

tACK


- **Overt ASICBoost support for S9 miners:** support for this
efficiency-improving feature was announced by both [Bitmain][bitmain oab]
and [Braiins][braiins oab] this week. Both covert and overt ASICBoost
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this sentence could be clearer. I've made an attempt in my commit, but I'm not sure if it's any better. Let me know what you think.

We could also link directly to one of the following:
the ASICboost paper : http://www.math.rwth-aachen.de/~Timo.Hanke/AsicBoostWhitepaperrev5.pdf
stack exchange answer: https://bitcoin.stackexchange.com/questions/43579/how-does-asicboost-work
blog post by ASICboost author: https://bitslog.wordpress.com/2017/04/10/the-relation-between-segwit-and-asicboost-covert-and-overt/

@jnewbery
Copy link
Contributor

@harding - I've pushed a suggested change in a commit. Feel free to squash it or drop it.

Otherwise looks great. ACK fbb4746

@moneyball - your changes look good. Thanks.

@harding harding force-pushed the 2018-10-30-newsletter branch 2 times, most recently from 9df0fde to 9f809c0 Compare October 30, 2018 10:02
@harding
Copy link
Collaborator Author

harding commented Oct 30, 2018

Thanks both of you! @jnewbery your description of ASICBoost was much better than mine!

I made a final small tweak to the introduction in and rephrased the text about Pierre's blog posts given that the residency program had more days than he has posts. For review, those changes are in commit d91a415 on a preservation of the full branch. Otherwise, I've squashed on this branch.

Thanks again!

@jnewbery
Copy link
Contributor

Thanks Dave. I've pushed one final change.

The residency was over 5 days, but the guest speakers gave their presentations on Mon-Thurs (Friday was left for residents to finish their projects and give demos). I've reworded the section to make it clear that Pierre's articles summarize all of the presentations. Let me know what you think.

@harding
Copy link
Collaborator Author

harding commented Oct 30, 2018

ACK 5b7f65e . Thanks!

@jnewbery jnewbery force-pushed the 2018-10-30-newsletter branch from 5b7f65e to b4bb58b Compare October 30, 2018 12:40
@jnewbery jnewbery merged commit 4522a44 into bitcoinops:master Oct 30, 2018
@jnewbery
Copy link
Contributor

squashed and merged

bitschmidty pushed a commit that referenced this pull request Oct 17, 2023
* newsletter-271: translate into Chinese

* Apply suggestions from code review

Co-authored-by: editor-Ajian <34365188+editor-Ajian@users.noreply.github.com>

* fix style

* Update _posts/zh/newsletters/2023-10-04-newsletter.md

Co-authored-by: freeyao <johnyao1526@gmail.com>

---------

Co-authored-by: Zhiwei(Jeffrey) Hu <huzhiwei@outlook.com>
Co-authored-by: editor-Ajian <34365188+editor-Ajian@users.noreply.github.com>
Co-authored-by: freeyao <johnyao1526@gmail.com>
harding pushed a commit to harding/bitcoinops.github.io that referenced this pull request Sep 27, 2024
* newsletter-271: translate into Chinese

* Apply suggestions from code review

Co-authored-by: editor-Ajian <34365188+editor-Ajian@users.noreply.github.com>

* fix style

* Update _posts/zh/newsletters/2023-10-04-newsletter.md

Co-authored-by: freeyao <johnyao1526@gmail.com>

---------

Co-authored-by: Zhiwei(Jeffrey) Hu <huzhiwei@outlook.com>
Co-authored-by: editor-Ajian <34365188+editor-Ajian@users.noreply.github.com>
Co-authored-by: freeyao <johnyao1526@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants