Skip to content

Makefile: test for broken reference-style links #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnewbery merged 2 commits into from
Nov 8, 2018
Merged

Makefile: test for broken reference-style links #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4b7a23
Posts: Xapo consolidation: fix bug, add excerpt
harding Nov 8, 2018
8fd562a
Makefile: add test for broken reference-style links
harding Nov 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,7 @@ build:
bundle exec jekyll build --future --drafts --unpublished

test:
## Check for broken Markdown reference-style links that are displayed in text unchanged, e.g. [broken][broken link]
! find _site/ -name '*.html' | xargs grep ']\[' | grep -v skip-test | grep .
Copy link
Contributor

@jnewbery jnewbery Nov 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the grep -v skip-test necessary?

Copy link
Collaborator Author

@harding harding Nov 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet here, but it's been used to solve issues in other repositories:

user@devbco:~/bitcoincore.org$ git grep skip-test
Makefile:       ! find _site/ -name '*.html' | xargs grep ']\[' | grep -v skip-test | grep .
_releases/0.14.0.md:`"proxy"`      | `getnetworkinfo()["networks"][0]["proxy"]` <!--skip-test-->
_releases/0.14.0.md:array index or a non-quoted string (i.e. `listunspent()[0][txid]`). <!--skip-test--> Both

Copy link
Contributor

@jnewbery jnewbery Nov 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

## Check for broken links
bundle exec htmlproofer --check-html --disable-external --url-ignore '/^\/bin/.*/' ./_site
4 changes: 4 additions & 0 deletions _posts/en/2018-07-30-xapo-consolidation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ type: posts
layout: post
lang: en
version: 1
excerpt: >
A field report from Anthony Towns, a developer at Xapo, about how they
consolidated around 4 million UTXOs to prepare for potential future
fee increases.
---

{:.post-meta}
Expand Down