Skip to content

Conversation

@jachiang
Copy link
Contributor

@jachiang jachiang commented Sep 4, 2019

Note: Previous feedback on this chapter.

@elichai
Copy link
Collaborator

elichai commented Sep 5, 2019

btw, when I run this I get:

AssertionError                            Traceback (most recent call last)
<ipython-input-1-579dc5073092> in <module>
      1 # Add Path to Bitcoin Core Testframework Library.
----> 2 import util
      3 
      4 from test_framework.key import ECKey, ECPubKey, SECP256K1_ORDER
      5 from test_framework.key import generate_schnorr_nonce, aggregate_schnorr_nonces

~/gits/taproot-workshop/util.py in <module>
     11 SOURCE_DIRECTORY = config["path"]["SOURCE_DIRECTORY"]
     12 
---> 13 assert not SOURCE_DIRECTORY == '', 'SOURCE_DIRECTORY not configured! Edit config.ini to configure SOURCE_DIRECTORY.'
     14 
     15 print("Source directory configured as {}".format(SOURCE_DIRECTORY))

AssertionError: SOURCE_DIRECTORY not configured! Edit config.ini to configure SOURCE_DIRECTORY.

I guess I need to clone your bitcoin fork, compile it and edit the config.ini

Copy link
Collaborator

@elichai elichai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great :)

Copy link
Collaborator

@elichai elichai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great :)

@jnewbery
Copy link
Contributor

jnewbery commented Sep 5, 2019

@elichai

btw, when I run this I get:
...
AssertionError: SOURCE_DIRECTORY not configured! Edit config.ini to configure SOURCE_DIRECTORY.

Can you run through the 0.1-test-notebook.ipynb notebook and verify that setting config.ini works for you. Also note the developer hint here: #12 (comment) so you don't need to change config.ini more than once.

@jachiang jachiang force-pushed the 2019-08-2.2-TapTweak-Chapter branch from 373d043 to cea00ad Compare September 15, 2019 20:56
@jachiang
Copy link
Contributor Author

jachiang commented Sep 15, 2019

Updated for this bitcoin taproot branch - includes updated MuSig module.

@jnewbery jnewbery force-pushed the 2019-08-2.2-TapTweak-Chapter branch from cea00ad to 57a4802 Compare September 17, 2019 14:57
@jnewbery
Copy link
Contributor

rebased on master

Copy link
Contributor

@bitschmidty bitschmidty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

Was able to run through all of the tests.

Pushed a commit to pull solutions into a text file

@jnewbery
Copy link
Contributor

rebased on master

@jnewbery jnewbery force-pushed the 2019-08-2.2-TapTweak-Chapter branch from bb7b305 to a8219d2 Compare September 21, 2019 22:00
@jnewbery jnewbery force-pushed the 2019-08-2.2-TapTweak-Chapter branch from 28ec8f8 to 719bdef Compare September 21, 2019 22:42
@jnewbery
Copy link
Contributor

I've run through this and all the code runs successfully, so I'm going to merge now.

I've addressed all of elichai's comments. I still plan to review this thoroughly myself.

@jnewbery jnewbery merged commit df36aed into bitcoinops:master Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants