-
Notifications
You must be signed in to change notification settings - Fork 116
Added Jupyter Chapter 2.2 (TapTweak) #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Jupyter Chapter 2.2 (TapTweak) #16
Conversation
|
btw, when I run this I get: I guess I need to clone your bitcoin fork, compile it and edit the |
elichai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great :)
elichai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great :)
Can you run through the |
373d043 to
cea00ad
Compare
|
Updated for this bitcoin taproot branch - includes updated MuSig module. |
cea00ad to
57a4802
Compare
|
rebased on master |
bitschmidty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
Was able to run through all of the tests.
Pushed a commit to pull solutions into a text file
|
rebased on master |
bb7b305 to
a8219d2
Compare
28ec8f8 to
719bdef
Compare
|
I've run through this and all the code runs successfully, so I'm going to merge now. I've addressed all of elichai's comments. I still plan to review this thoroughly myself. |
Note: Previous feedback on this chapter.