Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nested Maybe records #405

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

csamak
Copy link
Contributor

@csamak csamak commented Oct 18, 2024

Required ToMaybe, ToAlias, ToAliasReference instances for SqlMaybes
Also, required implementation changes to the sqlSelectProcessRow for SqlMaybes

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR.
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts).

Required ToMaybe, ToAlias, ToAliasReference instances for SqlMaybes
Also, required implementation changes to the sqlSelectProcessRow for
SqlMaybes
@parsonsmatt parsonsmatt self-requested a review October 18, 2024 14:08
Copy link
Collaborator

@parsonsmatt parsonsmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@parsonsmatt parsonsmatt merged commit d5df118 into bitemyapp:master Oct 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants