v1/orderbook: fix panic when sorting for checksum #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LKE20
added a commit
to trever-io/bitfinex-api-go
that referenced
this pull request
May 3, 2022
Sneaksolid
added a commit
to trever-io/bitfinex-api-go
that referenced
this pull request
May 9, 2022
[bitfinexcom#145] usage of string types for submitWithdrawals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checksum for the orderbook was sometimes throwing index out of range if the sides were not balances. This piece of code make sure the sort never operates out of bounds