Add account name to address book account name

[sunkup]

Purpose

#989 has renamed address book accounts. Now address book accounts don't include the actual account name anymore. This is desireable for usability though. This PR adds the actual account name back to the address book account name.

Short description

• Add the actual account name to the address book account name.
• Add some explaining comments

Checklist

• The PR has a proper title, description and label.
• I have self-reviewed the PR.
• I have added documentation to complex functions and functions that can be used by other modules.
• I have added reasonable tests or consciously decided to not add tests.

[ArnyminerZ]

Looks and works good for me.

[rfc2822]

When I use info.serviceId, it works and creates the address book accounts with the account name in the name.

However when the account is renamed (for instance from the version without account name because the service with service.id=info.id was not present to the one with account name), I get this exception:

Show Screenshot

To reproduce:

• Sync addressbook → address book account is created
• Change accountName function, for instance add a word for testing to the account name
• Sync addressbook again → address book is renamed, but notification is shown.

I think this will be addressed in #1039, no? I wonder how this happens because if the account name is changed, it should cause AccountManager.renameAccount() without data loss.

[sunkup]

I think this will be addressed in #1039, no?

Exactly. I started working this one, because only changing the account name should not interfere with the actual crash issue of old accounts not being deleted / renamed properly.

[rfc2822]

Nice 👍🏻