Syncer: make sure collections which are deleted are not synced #1065
+67
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
It works just fine and I thought of doing that too, but I think it's not explicit enough, since createCollections now has that sideeffect. Of course we can document it in the method KDoc, but as a general principle I was taught sideeffects are unclear and therefore dangerous, so I thought we would not want them in the sync code :) https://en.wikipedia.org/wiki/Side_effect_(computer_science) |
sunkup
approved these changes
Oct 10, 2024
sunkup
reviewed
Oct 10, 2024
| * - Deletes local collections if corresponding database collections are missing. | ||
| * | ||
| * - Deletes local collections if corresponding database collections are missing. If | ||
| * a local collection is removed because it's not in [dbCollections], **it becomes also removed from [localCollections]!** |
There was a problem hiding this comment.
This is documenting the sideeffect, but it would be better not to have the sideeffect in the first place IMO :)
rfc2822
deleted the
1062-syncer-tries-to-sync-collections-that-it-just-has-deleted-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe replaces #1064
@sunkup Does that not work for you?