-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize syncer #907
Generalize syncer #907
Conversation
c38fd6d
to
6911576
Compare
6911576
to
32a5e5f
Compare
This PR/issue depends on: |
5b61cb0
to
f421ad1
Compare
Please rebase/merge from main-ose, changed a lot of things (mainly DI) that also affect |
79feede
to
0d199a3
Compare
2f129dd
to
d56586b
Compare
d56586b
to
eceef11
Compare
@rfc2822 Ready :) I used a nullable string for the url property of LocalCollection, since JtxCollection requires it. We could make the change in ical4android of course, but I felt it was not really worth it, if we are going to change to the ID property soon anyways. Also the TaskSyncer still needs to acquire TaskProvider, see the PR description for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks already good with having the delete
and url
in the LocalCollection!
Did a few minor changes, and have some requests again.
- make sync private - use to autoclose provider
I have created bitfireAT/ical4android#161 for future improvement :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good now! Hope that everything will work as expected.
Purpose
The sync algorithm of the different syncer implementations is very similiar. One generalized sync algorithm in the abstract syncer, with implementation details in the implemented Syncers, is less error prone and easier to understand and test with unit tests.
Future error handling (#887) should become easier as well.
Short description
DmfsTaskList.find()
requires it, which would in turn require some more rewriting in ical4android.Checklist
Depends on #909