Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecations #409

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Fix deprecations #409

merged 4 commits into from
Sep 9, 2024

Conversation

ArnyminerZ
Copy link
Member

Purpose

There has been some Compose deprecations, fix them.

Short description

Replaced usages of animateItemPlacement by animateItem.

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ self-assigned this Sep 6, 2024
@ArnyminerZ ArnyminerZ added the refactoring Quality improvement of existing functions label Sep 6, 2024
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ requested a review from sunkup September 6, 2024 06:30
sunkup
sunkup previously approved these changes Sep 9, 2024
Copy link
Member

@sunkup sunkup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android studio tells me we still need the ExperimentalFoundationApi ?

…cations

# Conflicts:
#	app/src/main/java/at/bitfire/icsdroid/ui/screen/CalendarListScreen.kt
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ
Copy link
Member Author

🤔 Please try now, and remember to sync gradle

@sunkup sunkup self-requested a review September 9, 2024 09:47
@sunkup sunkup merged commit ae014c1 into dev Sep 9, 2024
7 checks passed
@sunkup sunkup deleted the fix-deprecations branch September 9, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Quality improvement of existing functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants