Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send setting value straight away #438

Conversation

sunkup
Copy link
Member

@sunkup sunkup commented Oct 1, 2024

Purpose

When collecting the sync interval setting flow the default value is emitted every time the app has a fresh start.

Short description

Send a first setting value for sync interval flow straight away buffered, such that we have the settingsvalue available straight away. This seems to prevent the use of the default value which is otherwise used.

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@sunkup sunkup added the bug Something isn't working label Oct 1, 2024
@sunkup sunkup added this to the 2.2.5 milestone Oct 1, 2024
@sunkup sunkup requested a review from ArnyminerZ October 1, 2024 13:12
@sunkup sunkup self-assigned this Oct 1, 2024
@ArnyminerZ ArnyminerZ merged commit fb32122 into dev Oct 2, 2024
8 checks passed
@ArnyminerZ ArnyminerZ deleted the 437-change-of-sync-interval-reverts-to-default-once-a-day-after-app-close-and-re-open branch October 2, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change of sync interval reverts to default ("Once a day") after app close and re-open
2 participants