Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement assignment operators #32

Closed
wants to merge 2 commits into from
Closed

Implement assignment operators #32

wants to merge 2 commits into from

Conversation

fiveop
Copy link
Contributor

@fiveop fiveop commented Jan 10, 2016

The patch implements assignment operators for bitflag structs.

If assignment operators become stable (rust-lang/rust#28235), it can be merged.

Currently, anyone using the bitflags macro would need to enable op_assign_traits for his crate

#![feature(op_assign_traits)]

and anyone using the assignment operators would need to enable augmented_assignments for his crate

#![feature(augmented_assignments)]

This includes the tests and doc tests, thus these fail as long as the feature is not stable.

@alexcrichton
Copy link
Contributor

Thanks for the PR! This is a nightly feature, however, and this is a stable crate, so we can't have this turned on by default. I would be ok putting it behind a feature, however.

Assignment operators can now be enabled using the crate feature
"assignment_operators".
@fiveop
Copy link
Contributor Author

fiveop commented Jan 13, 2016

Open a new Pull Request rebased on current master: #35.

@fiveop fiveop closed this Jan 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants