Skip to content

Conversation

@ysmoradi
Copy link
Member

@ysmoradi ysmoradi commented Sep 18, 2025

closes #11422

Summary by CodeRabbit

  • Refactor

    • Removed Aspire Dashboard integration from application startup.
    • Simplified startup flow by running the app without initializing the dashboard.
  • Chores

    • Eliminated automatic telemetry environment configuration (OTLP endpoint/protocol and service name) previously applied to resources.
    • Removed associated extension that added the dashboard and instrumentation.
  • Impact

    • The bundled dashboard and automatic OTLP instrumentation are no longer provided; configure observability via your preferred external setup if needed.

@coderabbitai
Copy link

coderabbitai bot commented Sep 18, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Removes the Aspire dashboard integration from the boilerplate app host by deleting the extension class that added/configured the dashboard and by removing its invocation in Program.cs. This eliminates dashboard container creation and automatic OTEL environment variable propagation during publish.

Changes

Cohort / File(s) Summary
Aspire dashboard extension removal
src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.AppHost/Extensions/IDistributedApplicationBuilderExtensions.cs
Deleted the Aspire.Hosting.IDistributedApplicationBuilderExtensions static class and AddAspireDashboard method, which previously created the dashboard container and set OTEL-related environment variables during publish.
Startup invocation cleanup
src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.AppHost/Program.cs
Removed the call to builder.AddAspireDashboard(); startup now builds and runs the application without initializing the dashboard.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Dev as Developer
  participant App as AppHost (Program)
  participant Dash as Aspire Dashboard
  participant Res as Resources

  rect rgba(230,245,255,0.6)
  note over App: Previous flow (before)
  Dev->>App: Run
  App->>App: builder.AddAspireDashboard()
  App->>Dash: Create dashboard container (publish)
  App->>Res: Set OTEL_* env per resource
  App->>App: Build and Run
  end

  rect rgba(235,255,235,0.6)
  note over App: Current flow (after)
  Dev->>App: Run
  App->>App: Build and Run
  note over Dash,Res: Dashboard and OTEL env not set here
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I nudge my nose at ports once bright,
The dashboard sails into the night.
Fewer carrots, cleaner rows,
Publish winds with lighter flows.
Thump-thump—logs still hum along,
OTEL waits where clouds belong.
Hare today, deploy strong. 🥕

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 5eae9ec and 78a07dd.

📒 Files selected for processing (2)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.AppHost/Extensions/IDistributedApplicationBuilderExtensions.cs (0 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.AppHost/Program.cs (0 hunks)

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ysmoradi ysmoradi merged commit 207e586 into bitfoundation:develop Sep 18, 2025
2 of 3 checks passed
@ysmoradi ysmoradi deleted the 11422 branch September 18, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bit Boilerplate project template publish time aspire dashboard has to be removed

1 participant