Treat ASP0018 warning as error in bit Boilerplate (#11455)

[ysmoradi]

closes #11455

Summary by CodeRabbit

• Bug Fixes

  • Improved Android alert handling when an unsupported WebView is detected to prevent UI blocking and ensure a smoother transition to the Google Play Store.

• Chores

  • Tightened build quality checks by treating an additional analyzer warning as an error.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Replaced a synchronous DisplayAlert with an asynchronous DisplayAlertAsync in the MAUI Android client when detecting an unsupported WebView, then proceeds to open the Google Play Store URL. Updated build configuration to treat analyzer warning ASP0018 as an error in Directory.Build.props.

Changes

Cohort / File(s)	Summary
MAUI client async alert adjustment src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Maui/App.xaml.cs	Switched from synchronous DisplayAlert to DisplayAlertAsync for the unsupported WebView notice; subsequent navigation to the Play Store remains unchanged.
Build warnings policy update src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props	Added ASP0018 to WarningsAsErrors, expanding analyzer warnings enforced as errors.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant App as MAUI App
  participant UI as Alert Dialog
  participant Store as Google Play Store

  User->>App: Launch app (Android)
  App->>App: Detect unsupported WebView
  App->>UI: DisplayAlertAsync(title, message)
  note over UI,App: Non-blocking async alert
  UI-->>App: User acknowledges
  App->>Store: Open Play Store URL

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I tapped my paws, alert and spry,
Async whispers in the sky—
A dialog pops, then off we go,
To Play Store paths the links now flow.
With warnings stern and errors tight,
This burrow’s code hops clean and bright. 🐇✨

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 16b11ce and f827273.

📒 Files selected for processing (2)

• src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Maui/App.xaml.cs (1 hunks)
• src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props (1 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}