-
-
Notifications
You must be signed in to change notification settings - Fork 260
Fix UI style issues of SignInPanel in Boilerplate (#11910) #11911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UI style issues of SignInPanel in Boilerplate (#11910) #11911
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe pull request refactors the external identity providers UI structure by reorganizing the ExternalIdentityProviders component layout with improved loading state handling and nested stack organization. Separator styling and logic are consolidated into ExternalIdentityProviders, removing redundant separators from SignUpPage and SignInPanel while updating responsive styling rules across affected SCSS files. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Pages/Identity/Components/ExternalIdentityProviders.razor (2)
8-11: Shimmer placeholder count may not match actual provider count.The loading state renders 4 shimmer placeholders, but there are 7 possible providers. Depending on the typical number of configured providers, users may notice a visual jump when loading completes.
Consider either matching the shimmer count to a representative number or dynamically calculating it if possible.
15-56: Consider consolidating provider rendering logic.The provider blocks follow an identical pattern. If the provider list grows or requires maintenance, a data-driven approach iterating over provider metadata (name, icon component, handler) could reduce repetition.
Current approach is clear and maintainable for 7 providers, so this is optional.
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
📒 Files selected for processing (5)
src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Pages/Identity/Components/ExternalIdentityProviders.razorsrc/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Pages/Identity/Components/ExternalIdentityProviders.razor.scsssrc/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Pages/Identity/SignIn/SignInPanel.razor.scsssrc/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Pages/Identity/SignUp/SignUpPage.razorsrc/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Pages/Identity/SignUp/SignUpPage.razor.scss
💤 Files with no reviewable changes (3)
- src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Pages/Identity/SignUp/SignUpPage.razor
- src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Pages/Identity/SignIn/SignInPanel.razor.scss
- src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Pages/Identity/SignUp/SignUpPage.razor.scss
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build Bit.Templates
🔇 Additional comments (2)
src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Pages/Identity/Components/ExternalIdentityProviders.razor.scss (1)
1-27: LGTM!The responsive separator utilities are well-structured. The
lg-sep/sm-seppattern cleanly ensures only one "Or" separator is visible at a time based on viewport width, with styles properly scoped via::deep.src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Pages/Identity/Components/ExternalIdentityProviders.razor (1)
60-64: LGTM!The separator logic correctly renders only when providers exist, and the dual-separator approach with responsive CSS classes elegantly handles different viewport stylings.
closes #11910
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.