-
-
Notifications
You must be signed in to change notification settings - Fork 260
Exclude TodoTableController when offlineDb disabled mode and sample is true (#11921) #11922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude TodoTableController when offlineDb disabled mode and sample is true (#11921) #11922
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughThe template.json configuration file in the Boilerplate template is updated to add two new exclusion paths for Todo-related controllers under the condition when offline database is disabled, refining which files are excluded during template generation. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR attempts to exclude Todo controller directories when the offlineDb feature is disabled by adding two exclusion patterns to the template configuration.
Key Changes:
- Adds exclusions for
src/Shared/Controllers/Todo/**andsrc/Server/Boilerplate.Server.Api/Controllers/Todo/**in theofflineDb != truecondition block
src/Templates/Boilerplate/Bit.Boilerplate/.template.config/template.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
📒 Files selected for processing (1)
src/Templates/Boilerplate/Bit.Boilerplate/.template.config/template.json
closes #11921
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.