Skip to content

Use get/set modifiers for BitNumberField value binding (#11926) #11929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msynk merged 1 commit into from
Dec 28, 2025
Merged

Use get/set modifiers for BitNumberField value binding (#11926) #11929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/BlazorUI/Bit.BlazorUI/Components/Inputs/NumberField/BitNumberField.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@namespace Bit.BlazorUI
@namespace Bit.BlazorUI
@inherits BitTextInputBase<TValue>
@typeparam TValue

Expand Down Expand Up @@ -110,9 +110,10 @@
@onkeydown="HandleOnKeyDown"
@onfocusin="HandleOnFocusIn"
@onfocusout="HandleOnFocusOut"
@onchange="HandleOnStringValueChangeAsync"
@oninput="HandleOnStringValueInputAsync"
@onwheel="HandleOnMouseWheel"
@bind-value:get="@CurrentValueAsString"
@bind-value:set="@HandleOnStringValueSet"
@bind-value:event="@(Immediate ? "oninput" : "onchange")"
form=""
min="@_min"
max="@_max"
Expand All @@ -126,7 +127,6 @@
inputmode="@_inputMode"
placeholder="@Placeholder"
aria-labelledby="@_labelId"
value="@CurrentValueAsString"
disabled="@(IsEnabled is false)"
class="bit-nfl-inp@(Mode == BitSpinButtonMode.Spread ? " bit-nfl-cin" : "") @Classes?.Input"
autocomplete="@(AutoComplete ?? "off")"
Expand Down
9 changes: 8 additions & 1 deletion src/BlazorUI/Bit.BlazorUI/Components/Inputs/NumberField/BitNumberField.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,14 @@ protected override Task HandleOnStringValueChangeAsync(ChangeEventArgs e)
return base.HandleOnStringValueChangeAsync(e);
}


async Task HandleOnStringValueSet(string? value)
{
var args = new ChangeEventArgs() { Value = value };
if (Immediate)
await HandleOnStringValueInputAsync(args);
else
await HandleOnStringValueChangeAsync(args);
}

private async Task HandleOnKeyDown(KeyboardEventArgs e)
{
Expand Down
Loading