Skip to content

Conversation

@nfsdns
Copy link
Contributor

@nfsdns nfsdns commented Jan 6, 2026

closes #11960

Summary by CodeRabbit

  • Chores
    • Updated and improved Persian language translations throughout the application for enhanced clarity and consistency.

✏️ Tip: You can customize this high-level summary in your review settings.

Copilot AI review requested due to automatic review settings January 6, 2026 09:15
@coderabbitai
Copy link

coderabbitai bot commented Jan 6, 2026

Walkthrough

A resource file for Persian localization was updated with schema restructuring (xsd:choice to xsd:sequence), whitespace reformatting, and translation refinements. No public API changes were introduced.

Changes

Cohort / File(s) Summary
Persian Resource Localization
src/Templates/Boilerplate/Bit.Boilerplate/src/Shared/Resources/AppStrings.fa.resx
ResX schema restructured from xsd:choice to xsd:sequence; extensive whitespace and indentation reformatting; Persian translation updates and consistency adjustments across resource entries (e.g., "سشن‌ها" → "نشست‌ها" for session-related keys); no changes to public API or code signatures.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 In Persian tongue, we hop with glee,
Translations bloom like clover spree,
Schema tidy, structure sound,
Each word refined and freshly crowned,
صداقت و وضوح—honesty in every line! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately describes the main change: editing the Persian resource file (AppStrings.fa.resx) to improve session translations, which is the primary focus of the changeset.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request improves Persian (Farsi) translations in the application's resource file, specifically focusing on replacing inconsistent "session" terminology with a more appropriate and professional Persian term.

Key Changes:

  • Replaced "جلسه - سشن" (session - transliteration) with "نشست" (proper Persian word for session) throughout the file
  • Standardized the translation to use consistent Persian terminology instead of mixing Persian with transliterations
  • Applied consistent XML formatting/indentation across the entire resource file

@nfsdns nfsdns force-pushed the 11960-translation-edit-for-session branch from 40cc0c3 to e1195be Compare January 6, 2026 09:19
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Fix all issues with AI Agents
In
@src/Templates/Boilerplate/Bit.Boilerplate/src/Shared/Resources/AppStrings.fa.resx:
- Around line 1249-1251: The resource entry for data name "DisableNotifications"
contains a typo in the Persian value; replace the current value "فیر فعال‌سازی
اعلان‌ها" with the correct phrase "غیرفعال‌سازی اعلان‌ها" so the translated
string reads properly for the DisableNotifications resource.
- Around line 903-905: Fix the typo in the resource entry named "SignInByOtp":
change the Persian value from "استفاده از رمز بک بار مصرف" to "استفاده از رمز یک
بار مصرف" so the phrase correctly reads "one-time use"; update the <value>
content for the data element with name "SignInByOtp".
📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between e0b7d46 and 40cc0c3.

📒 Files selected for processing (1)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Shared/Resources/AppStrings.fa.resx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Agent
🔇 Additional comments (3)
src/Templates/Boilerplate/Bit.Boilerplate/src/Shared/Resources/AppStrings.fa.resx (3)

63-120: Schema and headers look correct.

The XML schema structure and ResX headers follow the standard .NET resource file format. The changes appear to be whitespace/indentation normalization only.


229-250: Session translations look good.

The consistent use of "نشست" (the native Persian term) instead of "سشن" (English transliteration) or "جلسات" (meetings) is a proper localization improvement that aligns with standard Persian UI terminology.


1265-1267: Session translations in management section are consistent.

All session-related strings in the user/role management section correctly use "نشست" terminology, maintaining consistency with the earlier session-related translations.

Also applies to: 1292-1294, 1298-1300, 1304-1309, 1325-1327, 1337-1339

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Saleh Yusefnejad <msynk@outlook.com>
Signed-off-by: Saleh Yusefnejad <msynk@outlook.com>
@msynk msynk changed the title Edit Appstring Fa to improve session translation (#11960) Edit AppStrings.fa.resx to improve session translation (#11960) Jan 6, 2026
@msynk msynk changed the title Edit AppStrings.fa.resx to improve session translation (#11960) Edit AppStrings.fa.resx to improve session translation in Boilerplate project template (#11960) Jan 6, 2026
@msynk msynk changed the title Edit AppStrings.fa.resx to improve session translation in Boilerplate project template (#11960) Edit AppStrings.fa.resx to improve session translation in Boilerplate (#11960) Jan 6, 2026
@msynk msynk merged commit bc01ef8 into bitfoundation:develop Jan 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Persian translation for the word "Session"

2 participants