-
-
Notifications
You must be signed in to change notification settings - Fork 258
Edit AppStrings.fa.resx to improve session translation in Boilerplate (#11960) #11961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit AppStrings.fa.resx to improve session translation in Boilerplate (#11960) #11961
Conversation
WalkthroughA resource file for Persian localization was updated with schema restructuring (xsd:choice to xsd:sequence), whitespace reformatting, and translation refinements. No public API changes were introduced. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request improves Persian (Farsi) translations in the application's resource file, specifically focusing on replacing inconsistent "session" terminology with a more appropriate and professional Persian term.
Key Changes:
- Replaced "جلسه - سشن" (session - transliteration) with "نشست" (proper Persian word for session) throughout the file
- Standardized the translation to use consistent Persian terminology instead of mixing Persian with transliterations
- Applied consistent XML formatting/indentation across the entire resource file
src/Templates/Boilerplate/Bit.Boilerplate/src/Shared/Resources/AppStrings.fa.resx
Outdated
Show resolved
Hide resolved
40cc0c3 to
e1195be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI Agents
In
@src/Templates/Boilerplate/Bit.Boilerplate/src/Shared/Resources/AppStrings.fa.resx:
- Around line 1249-1251: The resource entry for data name "DisableNotifications"
contains a typo in the Persian value; replace the current value "فیر فعالسازی
اعلانها" with the correct phrase "غیرفعالسازی اعلانها" so the translated
string reads properly for the DisableNotifications resource.
- Around line 903-905: Fix the typo in the resource entry named "SignInByOtp":
change the Persian value from "استفاده از رمز بک بار مصرف" to "استفاده از رمز یک
بار مصرف" so the phrase correctly reads "one-time use"; update the <value>
content for the data element with name "SignInByOtp".
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
📒 Files selected for processing (1)
src/Templates/Boilerplate/Bit.Boilerplate/src/Shared/Resources/AppStrings.fa.resx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Agent
🔇 Additional comments (3)
src/Templates/Boilerplate/Bit.Boilerplate/src/Shared/Resources/AppStrings.fa.resx (3)
63-120: Schema and headers look correct.The XML schema structure and ResX headers follow the standard .NET resource file format. The changes appear to be whitespace/indentation normalization only.
229-250: Session translations look good.The consistent use of "نشست" (the native Persian term) instead of "سشن" (English transliteration) or "جلسات" (meetings) is a proper localization improvement that aligns with standard Persian UI terminology.
1265-1267: Session translations in management section are consistent.All session-related strings in the user/role management section correctly use "نشست" terminology, maintaining consistency with the earlier session-related translations.
Also applies to: 1292-1294, 1298-1300, 1304-1309, 1325-1327, 1337-1339
src/Templates/Boilerplate/Bit.Boilerplate/src/Shared/Resources/AppStrings.fa.resx
Outdated
Show resolved
Hide resolved
src/Templates/Boilerplate/Bit.Boilerplate/src/Shared/Resources/AppStrings.fa.resx
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Saleh Yusefnejad <msynk@outlook.com>
Signed-off-by: Saleh Yusefnejad <msynk@outlook.com>
closes #11960
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.