Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icon page render issue (#1861) #1880

Closed
wants to merge 1 commit into from
Closed

Fix icon page render issue (#1861) #1880

wants to merge 1 commit into from

Conversation

sajadkardel
Copy link
Contributor

this closes #1861

@msynk
Copy link
Member

msynk commented Apr 15, 2022

@maryamhdr & @Cyrus-Sushiant plz review this PR

@msynk
Copy link
Member

msynk commented Apr 15, 2022

@ysmoradi could you please check if the slowness issue is resolved with this PR?

@ysmoradi
Copy link
Member

@ysmoradi could you please check if the slowness issue is resolved with this PR?

Sure, I'm on it

@ysmoradi
Copy link
Member

It opens without hanging due to the fact that we're using virtualization at the moment.
But when I scroll up or down, items react weirdly! /-:

image
Then I scroll down a little
image

If this is a hard to solve problem, then ignore it, but if not, let's fix it.

@msynk
Copy link
Member

msynk commented Apr 17, 2022

There is an issue in the Virtualize component that is used in the BitBasicList component, and it seems it is not going to be addressed soon based on the conversation in this Github issue:
dotnet/aspnetcore#28821
this requested feature is what we actually need for resolving this issue. so we need to think about other solutions.

@vintagemarianne
Copy link
Contributor

There is an issue in the Virtualize component that is used in the BitBasicList component, and it seems it is not going to be addressed soon based on the conversation in this Github issue: dotnet/aspnetcore#28821 this requested feature is what we actually need for resolving this issue. so we need to think about other solutions.

So let's talk about it :)

@msynk
Copy link
Member

msynk commented Apr 18, 2022

Since we decided to apply another approach to resolve this issue, I'm closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Render issues of the Iconography page in the BitBlazorUI demo project
4 participants