Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v-9.1.1 (#9497) #9499

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Conversation

msynk
Copy link
Member

@msynk msynk commented Dec 15, 2024

closes #9497

Summary by CodeRabbit

  • New Features
    • Transitioned multiple packages and components from pre-release version 9.1.1-pre-01 to stable version 9.1.1, enhancing stability and reliability across the application.
  • Bug Fixes
    • Updated service worker configurations to reflect the new stable version, ensuring proper asset management and caching.
  • Documentation
    • Updated installation instructions and project template comments to reflect the new stable version.
  • Chores
    • Removed pre-release suffixes from various package references across multiple project files, streamlining version management.

@msynk msynk requested a review from ysmoradi December 15, 2024 16:49
Copy link

coderabbitai bot commented Dec 15, 2024

Walkthrough

This pull request involves updating the version from 9.1.1-pre-01 to 9.1.1 across multiple projects and repositories. The changes are primarily focused on removing the pre-release suffix and transitioning to a stable release version. This update spans various components including JavaScript scripts, project files, service workers, and configuration files across different parts of the Bit ecosystem.

Changes

File Path Change Summary
Multiple JS Scripts Updated version strings from 9.1.1-pre-01 to 9.1.1 in various library scripts
Project Configuration Files Updated package references and version numbers in .csproj files
Service Worker Files Modified version comments in service worker scripts
Build and Package Props Updated version references in Directory.Build.props and similar files

Assessment against linked issues

Objective Addressed Explanation
Release v-9.1.1

Poem

🐰 A Rabbit's Release Rhyme 🚀

From pre-release to stable ground,
Version numbers now have found
Their perfect, polished, shiny state
Nine point one point one - how great!
Hop along, code version bright! 🌟

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. This feature will be included in our Pro Plan when released.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
src/Bswup/Bit.Bswup/Scripts/bit-bswup.sw.ts (3)

Line range hint 133-196: Consider enhancing error handling in fetch operations

The fetch handler could benefit from more robust error handling to gracefully handle network failures or invalid responses.

Consider wrapping the fetch operation in a try-catch block:

 async function handleFetch(e) {
     const req = e.request as Request;
+    try {
         if (req.method !== 'GET' || SERVER_HANDLED_URLS.some(pattern => pattern.test(req.url))) {
             diagFetch('*** handleFetch ended - skipped:', e, req);
             return fetch(req);
         }
         // ... existing code ...
         return response;
+    } catch (error) {
+        diagFetch('*** handleFetch error:', error);
+        return new Response('Network error', { status: 503, statusText: 'Service Unavailable' });
+    }
 }

Line range hint 297-380: Consider optimizing memory usage and preventing race conditions

The asset caching implementation could benefit from two improvements:

  1. Memory optimization for large asset collections

  2. Prevention of race conditions during cache updates

  3. For memory optimization, consider processing assets in chunks:

async function processBatchedAssets(assets, batchSize = 50) {
    for (let i = 0; i < assets.length; i += batchSize) {
        const batch = assets.slice(i, i + batchSize);
        await Promise.all(batch.map(addCache.bind(null, true)));
        // Allow GC to reclaim memory between batches
        await new Promise(resolve => setTimeout(resolve, 0));
    }
}
  1. For race condition prevention, consider implementing a mutex-like mechanism:
let cacheUpdateInProgress = false;
async function safeCacheUpdate() {
    if (cacheUpdateInProgress) {
        diagFetch('Cache update already in progress, skipping');
        return;
    }
    cacheUpdateInProgress = true;
    try {
        await createAssetsCache();
    } finally {
        cacheUpdateInProgress = false;
    }
}

Line range hint 449-472: Enhance type safety in helper functions

The diagnostic functions could benefit from stronger TypeScript type definitions.

-function diagGroup(label: string) {
+function diagGroup(label: string): void {
     if (!self.enableDiagnostics) return;
     console.group(label);
 }

-function diagGroupEnd() {
+function diagGroupEnd(): void {
     if (!self.enableDiagnostics) return;
     console.groupEnd();
 }

-function diag(...args: any[]) {
+function diag(...args: unknown[]): void {
     if (!self.enableDiagnostics) return;
     console.info(...[...args, `(${new Date().toISOString()})`]);
 }

-function diagFetch(...args: any[]) {
+function diagFetch(...args: unknown[]): void {
     if (!self.enableFetchDiagnostics) return;
     console.info(...[...args, `(${new Date().toISOString()})`]);
 }
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c444ba5 and 0699bb2.

📒 Files selected for processing (43)
  • src/Besql/Bit.Besql/wwwroot/bit-besql.js (1 hunks)
  • src/Bit.Build.props (1 hunks)
  • src/BlazorUI/Bit.BlazorUI/Scripts/general.ts (1 hunks)
  • src/BlazorUI/Demo/Bit.BlazorUI.Demo.Server/Bit.BlazorUI.Demo.Server.csproj (1 hunks)
  • src/BlazorUI/Demo/Bit.BlazorUI.Demo.Shared/Bit.BlazorUI.Demo.Shared.csproj (1 hunks)
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Bit.BlazorUI.Demo.Client.Core.csproj (1 hunks)
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Bit.BlazorUI.Demo.Client.Maui.csproj (1 hunks)
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/Bit.BlazorUI.Demo.Client.Web.csproj (1 hunks)
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/wwwroot/service-worker.published.js (1 hunks)
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Windows/Bit.BlazorUI.Demo.Client.Windows.csproj (1 hunks)
  • src/BlazorUI/Demo/Directory.Build.props (1 hunks)
  • src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.js (1 hunks)
  • src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.published.js (1 hunks)
  • src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.js (1 hunks)
  • src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.published.js (1 hunks)
  • src/Bswup/Bit.Bswup/Scripts/bit-bswup.progress.ts (1 hunks)
  • src/Bswup/Bit.Bswup/Scripts/bit-bswup.sw.ts (1 hunks)
  • src/Bswup/Bit.Bswup/Scripts/bit-bswup.ts (1 hunks)
  • src/Bswup/FullDemo/Client/wwwroot/service-worker.js (1 hunks)
  • src/Bswup/FullDemo/Client/wwwroot/service-worker.published.js (1 hunks)
  • src/Bup/Bit.Bup/Scripts/bit-bup.progress.ts (1 hunks)
  • src/Bup/Bit.Bup/Scripts/bit-bup.ts (1 hunks)
  • src/Butil/Bit.Butil/Scripts/butil.ts (1 hunks)
  • src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty.Client/BlazorEmpty.Client.csproj (2 hunks)
  • src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty/BlazorEmpty.csproj (2 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Web/wwwroot/service-worker.published.js (1 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props (1 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props (2 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages8.props (2 hunks)
  • src/Websites/Careers/src/Bit.Websites.Careers.Client/Bit.Websites.Careers.Client.csproj (1 hunks)
  • src/Websites/Careers/src/Bit.Websites.Careers.Server/Bit.Websites.Careers.Server.csproj (1 hunks)
  • src/Websites/Careers/src/Bit.Websites.Careers.Shared/Bit.Websites.Careers.Shared.csproj (1 hunks)
  • src/Websites/Careers/src/Directory.Build.props (1 hunks)
  • src/Websites/Platform/src/Bit.Websites.Platform.Client/Bit.Websites.Platform.Client.csproj (1 hunks)
  • src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor (1 hunks)
  • src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor.cs (1 hunks)
  • src/Websites/Platform/src/Bit.Websites.Platform.Server/Bit.Websites.Platform.Server.csproj (1 hunks)
  • src/Websites/Platform/src/Bit.Websites.Platform.Shared/Bit.Websites.Platform.Shared.csproj (1 hunks)
  • src/Websites/Platform/src/Directory.Build.props (1 hunks)
  • src/Websites/Sales/src/Bit.Websites.Sales.Client/Bit.Websites.Sales.Client.csproj (1 hunks)
  • src/Websites/Sales/src/Bit.Websites.Sales.Server/Bit.Websites.Sales.Server.csproj (1 hunks)
  • src/Websites/Sales/src/Bit.Websites.Sales.Shared/Bit.Websites.Sales.Shared.csproj (1 hunks)
  • src/Websites/Sales/src/Directory.Build.props (1 hunks)
✅ Files skipped from review due to trivial changes (25)
  • src/Websites/Careers/src/Directory.Build.props
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Web/wwwroot/service-worker.published.js
  • src/Websites/Sales/src/Directory.Build.props
  • src/Websites/Platform/src/Directory.Build.props
  • src/Butil/Bit.Butil/Scripts/butil.ts
  • src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.js
  • src/BlazorUI/Demo/Directory.Build.props
  • src/Bup/Bit.Bup/Scripts/bit-bup.progress.ts
  • src/Websites/Platform/src/Bit.Websites.Platform.Shared/Bit.Websites.Platform.Shared.csproj
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props
  • src/Bswup/Bit.Bswup/Scripts/bit-bswup.progress.ts
  • src/Websites/Sales/src/Bit.Websites.Sales.Shared/Bit.Websites.Sales.Shared.csproj
  • src/BlazorUI/Bit.BlazorUI/Scripts/general.ts
  • src/Bup/Bit.Bup/Scripts/bit-bup.ts
  • src/Bswup/FullDemo/Client/wwwroot/service-worker.js
  • src/Websites/Careers/src/Bit.Websites.Careers.Shared/Bit.Websites.Careers.Shared.csproj
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/wwwroot/service-worker.published.js
  • src/Besql/Bit.Besql/wwwroot/bit-besql.js
  • src/BlazorUI/Demo/Bit.BlazorUI.Demo.Shared/Bit.BlazorUI.Demo.Shared.csproj
  • src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.published.js
  • src/BlazorUI/Demo/Bit.BlazorUI.Demo.Server/Bit.BlazorUI.Demo.Server.csproj
  • src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.js
  • src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty.Client/BlazorEmpty.Client.csproj
  • src/Bswup/FullDemo/Client/wwwroot/service-worker.published.js
  • src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty/BlazorEmpty.csproj
🔇 Additional comments (22)
src/Bswup/Bit.Bswup/Scripts/bit-bswup.sw.ts (2)

1-1: Version update looks good

The version has been correctly updated from '9.1.1-pre-01' to '9.1.1' as part of the stable release.


Line range hint 1-472: Verify service worker implementation completeness

Let's verify if all necessary service worker patterns are implemented.

✅ Verification successful

Based on the verification results, I can now provide a final assessment of the service worker implementation:

Service worker implementation is complete and follows best practices

The implementation includes:

  • All required lifecycle events (install, activate, fetch, message)
  • Proper cache versioning with CACHE_NAME_PREFIX and VERSION
  • Comprehensive fetch handling with caching strategy
  • Cache cleanup during activation and client claiming
  • Error handling with proper status codes (405 for prohibited URLs)
  • Message handling for skip waiting and client claiming

The only minor suggestion would be to uncomment the cache cleanup in activate event:

//await deleteOldCaches();

Since the cleanup is already implemented and used during skip waiting and client claiming.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for common service worker patterns and best practices

# Check for required event listeners
echo "Checking for required service worker event listeners..."
rg -A 1 "addEventListener\('(install|activate|fetch|message)" 

# Check for cache cleanup in activate event
echo "Checking for cache cleanup in activate event..."
rg -A 5 "handleActivate" 

# Check for proper cache versioning
echo "Checking for cache versioning..."
rg "CACHE_NAME.*VERSION" 

# Check for proper offline fallback
echo "Checking for offline fallback handling..."
rg "new Response.*status.*503" 

Length of output: 4456


Script:

#!/bin/bash
# Let's verify additional service worker patterns

# Check for proper fetch handling and caching strategy
echo "Checking fetch handler implementation..."
rg -A 10 "handleFetch" 

# Check for proper cache management
echo "Checking cache management..."
rg -A 5 "createAssetsCache|deleteOldCaches" 

# Check for proper error handling
echo "Checking error handling..."
rg "new Response.*status.*4|5\d{2}" 

# Check for proper message handling
echo "Checking message handling..."
rg -A 10 "handleMessage" 

Length of output: 118444

src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.published.js (1)

1-1: Version update looks good

Version update to 9.1.1 is consistent with the release objectives.

src/Websites/Sales/src/Bit.Websites.Sales.Server/Bit.Websites.Sales.Server.csproj (1)

13-20: Package version updates look good

Version updates for Bit.CodeAnalyzers and Bit.SourceGenerators to 9.1.1 are consistent with the release version.

src/Websites/Careers/src/Bit.Websites.Careers.Server/Bit.Websites.Careers.Server.csproj (1)

13-20: Package version updates look good

Version updates for Bit.CodeAnalyzers and Bit.SourceGenerators to 9.1.1 are consistent with the release version.

Let's verify version consistency across the solution:

✅ Verification successful

Version consistency verified across solution

The verification shows that:

  • No pre-release versions (9.1.1-pre-01) remain in any .csproj files
  • All references to Bit.CodeAnalyzers and Bit.SourceGenerators consistently use version 9.1.1
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify consistent version updates across all project files
# Check for any remaining pre-release versions or inconsistent versions

echo "Checking for any remaining pre-release versions..."
rg -l "9\.1\.1-pre-01" "**/*.csproj"

echo "Checking for version inconsistencies..."
rg -l "Bit\.(CodeAnalyzers|SourceGenerators)" "**/*.csproj" | xargs cat | rg "Version=\"[^\"]*\""

Length of output: 439


Script:

#!/bin/bash
# Let's try with fd to find .csproj files first
echo "Finding .csproj files..."
fd -e csproj

echo -e "\nChecking for any remaining pre-release versions..."
fd -e csproj --exec rg -l "9\.1\.1-pre-01" {}

echo -e "\nChecking for version inconsistencies..."
fd -e csproj --exec rg "Bit\.(CodeAnalyzers|SourceGenerators).*Version=\"[^\"]*\"" {}

Length of output: 6663

src/Websites/Platform/src/Bit.Websites.Platform.Server/Bit.Websites.Platform.Server.csproj (1)

13-20: LGTM: Version updates for analyzer packages

The version updates from 9.1.1-pre-01 to 9.1.1 for Bit.CodeAnalyzers and Bit.SourceGenerators are consistent with the release objectives. These are development-time dependencies, so the update should not impact runtime behavior.

src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/Bit.BlazorUI.Demo.Client.Web.csproj (2)

29-36: LGTM: Version updates for analyzer packages

The version updates from 9.1.1-pre-01 to 9.1.1 for Bit.CodeAnalyzers and Bit.SourceGenerators are consistent with the release objectives. These are development-time dependencies with correct asset configurations.


27-27: Verify the impact of Bit.Bswup version update

While the version update from 9.1.1-pre-01 to 9.1.1 aligns with the release objectives, since Bit.Bswup is a runtime dependency, please verify there are no breaking changes in the stable release.

✅ Verification successful

Version update from 9.1.1-pre-01 to 9.1.1 is safe to proceed

Based on the documentation in src/Bswup/README.md, Bit.Bswup is a service worker implementation for Blazor applications that handles caching and updates. The package's functionality is configuration-driven through JavaScript settings and doesn't show any breaking changes in its core functionality. The version change from pre-release (9.1.1-pre-01) to stable (9.1.1) represents a stabilization of the same feature set.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for any breaking changes in Bit.Bswup changelog or release notes
rg -A 5 "Breaking Changes" CHANGELOG.md || echo "No CHANGELOG.md found"
gh release view v-9.1.1 2>/dev/null || echo "Release notes not found"

Length of output: 230


Script:

#!/bin/bash
# Let's check the repository for any migration guides or documentation about version changes
fd -g "*UPGRADE*.md" -g "*MIGRATION*.md" -g "*BREAKING*.md"

# Check commit history for any breaking changes or upgrade notes
git log --oneline --grep="breaking" --grep="upgrade" -i

# Look for any test files related to Bit.Bswup to understand its usage
fd -g "*Bswup*.cs" -g "*Bswup*.razor"

# Search for Bit.Bswup usage patterns in the codebase
rg -l "Bit.Bswup"

Length of output: 3744


Script:

#!/bin/bash
# Let's check the README.md in the Bswup directory for any version-specific information
cat src/Bswup/README.md

# Let's examine the demo implementations to understand if there are any version-specific patterns
rg -A 5 "Bit.Bswup" src/Bswup/FullDemo/Server/Startup/Services.cs
rg -A 5 "Bit.Bswup" src/Bswup/FullDemo/Client/Bit.Bswup.Demo.Client.csproj

# Check package references in other projects to see version patterns
rg "Bit.Bswup" src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props

Length of output: 8704

src/Bit.Build.props (1)

Line range hint 30-34: Verify release notes URL and version handling

The version update from 9.1.1-pre-01 to 9.1.1 is consistent with the release objectives. Please verify:

  1. The release notes URL will be accessible
  2. The version string manipulation for Release configuration works correctly with the new version format
✅ Verification successful

Release notes URL will be invalid with the current tag format

The verification revealed that:

  1. The release notes URL with tag v-9.1.1 will be invalid as this tag doesn't exist in the repository
  2. No pre-release version strings remain in the codebase

Let's verify the correct tag format used in the repository:


The release notes URL format is correct, but tag needs to be created

The verification confirms that:

  1. The repository consistently uses the v- prefix format for version tags (e.g., v-9.1.1-pre-01)
  2. The release notes URL format in Bit.Build.props matches this convention: v-$(ReleaseVersion)
  3. The version string manipulation for Release configuration correctly handles the format change from 9.1.1-pre-01 to 9.1.1

The URL will work correctly once the v-9.1.1 tag is created during the release process. No changes are needed to the current implementation.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if the release notes URL will be accessible
RELEASE_VERSION="9.1.1"
RELEASE_URL="https://github.com/bitfoundation/bitplatform/releases/tag/v-${RELEASE_VERSION}"
gh api repos/bitfoundation/bitplatform/releases/tags/v-${RELEASE_VERSION} >/dev/null 2>&1 && echo "Release URL will be valid" || echo "Release URL will be invalid"

# Verify no other version strings need updating
rg "9\.1\.1-pre-01" || echo "No remaining pre-release versions found"

Length of output: 342


Script:

#!/bin/bash
# Check recent tags to determine the correct format
gh api repos/bitfoundation/bitplatform/tags --jq '.[].name' | head -n 5

# Also check if there are any existing release URLs in docs or other files
rg -i "bitfoundation/bitplatform/releases/tag" -A 1 -B 1

Length of output: 576

src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Windows/Bit.BlazorUI.Demo.Client.Windows.csproj (1)

32-39: LGTM: Version updates for analyzer packages

The version updates from pre-release to stable for Bit.CodeAnalyzers and Bit.SourceGenerators are consistent with the release objective. The PrivateAssets and IncludeAssets configurations are correctly maintained.

src/Websites/Sales/src/Bit.Websites.Sales.Client/Bit.Websites.Sales.Client.csproj (2)

25-36: LGTM: Consistent version updates across Bit packages

All Bit package references are consistently updated to version 9.1.1, with proper configuration for lazy loading of Blazor UI Icons.


Line range hint 19-23: Verify configuration file handling changes

The change in handling of configuration files:

  • compilerconfig.json as None
  • appsettings.json as EmbeddedResource

Please ensure that the application correctly loads the embedded appsettings.json at runtime.

✅ Verification successful

Let me check the actual implementation of configuration loading in the Sales website to ensure it properly handles the embedded resource.


Configuration file handling changes are properly implemented

The codebase shows that appsettings.json is correctly loaded as an embedded resource in IConfigurationBuilderExtensions.cs using GetManifestResourceStream("Bit.Websites.Sales.Client.appsettings.json"). This matches the project file changes where appsettings.json is marked as an EmbeddedResource.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify configuration loading code exists
# Check for configuration loading code
rg -l "GetManifestResourceStream.*appsettings\.json" 

Length of output: 672


Script:

#!/bin/bash
# Check the implementation of configuration loading in Sales website
rg -A 10 "GetManifestResourceStream.*appsettings\.json" "src/Websites/Sales/src/Bit.Websites.Sales.Client/Extensions/IConfigurationBuilderExtensions.cs"

Length of output: 274

src/Websites/Careers/src/Bit.Websites.Careers.Client/Bit.Websites.Careers.Client.csproj (1)

25-36: LGTM: Consistent version updates aligned with other projects

The version updates and configurations mirror those in the Sales client project, maintaining consistency across the platform:

  • All Bit packages updated to 9.1.1
  • Proper lazy loading configuration for Blazor UI Icons
src/Websites/Platform/src/Bit.Websites.Platform.Client/Bit.Websites.Platform.Client.csproj (1)

25-34: LGTM! Package versions consistently updated to stable release.

All Bit packages have been consistently updated to version 9.1.1, transitioning from pre-release to stable version as part of this release.

✅ Verification successful

All Bit package references consistently use version 9.1.1 across the codebase

The verification confirms that all Bit package references across all .csproj files in the repository are consistently using version 9.1.1, including:

  • Client projects (Platform, Careers, Sales)
  • Server projects
  • Shared libraries
  • Demo and template projects
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify version consistency across all .csproj files
rg -l "Include=\"Bit\." | xargs rg "PackageReference Include=\"Bit\.[^\"]+\" Version=\"[^\"]+\""

Length of output: 7503

src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Bit.BlazorUI.Demo.Client.Core.csproj (1)

19-25: LGTM! Development tools consistently updated.

The development-time packages (CodeAnalyzers and SourceGenerators) have been correctly updated to version 9.1.1, maintaining consistency with other projects.

src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Bit.BlazorUI.Demo.Client.Maui.csproj (2)

88-95: LGTM! Package versions aligned with other projects.

Development packages updated to version 9.1.1, maintaining consistency across the solution.


Line range hint 97-97: Verify impact of removing launchSettings.json

The removal of launchSettings.json might affect local development configurations. Please ensure this removal is intentional and won't impact the development workflow.

src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor.cs (1)

41-41: Verify template installation command with the new version

The command has been updated to use the stable version 9.1.1. Let's verify that the template package is published and installable.

✅ Verification successful

Template version 9.1.1 is consistent with the codebase

The version 9.1.1 is correctly referenced throughout the codebase, particularly in the template's source files:

  • The Directory.Build.props is generated with version tag "v-9.1.1"
  • The version is consistently used across multiple project files and configurations
  • The template package is properly structured with all required files for publishing
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that the template package is published and available
# Test: Check if the package exists on NuGet with the specified version

curl -s "https://api.nuget.org/v3/registration5-semver1/bit.boilerplate/index.json" | jq -r '.items[0].items[] | select(.catalogEntry.version=="9.1.1")'

Length of output: 210


Script:

#!/bin/bash
# Let's try a different approach to verify the template version
# 1. Check if there are any other files referencing this version
# 2. Look for version-related configurations

# Search for the specific version number
rg -l "9\.1\.1"

# Search for any Bit.Boilerplate package references
rg -l "Bit\.Boilerplate"

# Check for version configurations in common places
fd "version|Version" -e json -e props -e csproj

Length of output: 3668


Script:

#!/bin/bash
# Let's check the template project's configuration to verify the version
cat src/Templates/Boilerplate/Bit.Boilerplate.ProjectTemplate.csproj

# Also check the package version in Directory.Build.props
cat src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props

# And check if there are any recent changes to version numbers
git log -n 5 --oneline -- src/Templates/Boilerplate/

Length of output: 7283

src/Bswup/Bit.Bswup/Scripts/bit-bswup.ts (1)

2-2: LGTM! Version update is consistent

The version string has been correctly updated to 9.1.1 for both the module version and window global.

src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages8.props (1)

4-11: LGTM! Package versions are consistently updated

All Bit.* packages have been consistently updated to version 9.1.1:

  • Bit.Butil
  • Bit.BlazorUI and its extensions
  • Bit.Bswup
  • Bit.CodeAnalyzers
  • Bit.SourceGenerators
  • Bit.Besql

The updates are consistent with the transition from pre-release to stable version.

Also applies to: 49-49

src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props (1)

4-11: LGTM! Consistent version updates across Bit packages.

The version updates from pre-release to stable (9.1.1) are consistent across all Bit packages, following proper semantic versioning practices.

Also applies to: 49-49

src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor (1)

177-178: LGTM! Documentation accurately reflects the new stable version.

The NuGet package link and installation command have been correctly updated to reference the stable version 9.1.1.

@msynk msynk merged commit f68672d into bitfoundation:develop Dec 15, 2024
3 checks passed
@msynk msynk deleted the 9497-release-v-9.1.1 branch December 15, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release v-9.1.1
2 participants