Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Not found message appears when all elements fits the search criteria #245

Closed
PabloPerezAguilo opened this issue Aug 2, 2020 · 1 comment · Fixed by #247
Closed

[BUG] Not found message appears when all elements fits the search criteria #245

PabloPerezAguilo opened this issue Aug 2, 2020 · 1 comment · Fixed by #247
Assignees
@macjohnny
Labels
bug Something isn't working
Milestone
v3.0.2

Comments

@PabloPerezAguilo
Copy link

PabloPerezAguilo commented Aug 2, 2020 •
edited
Loading

Describe the bug
When every item fits the search criteria, the "not found" message appears

To Reproduce

  1. Go to https://stackblitz.com/github/bithost-gmbh/ngx-mat-select-search-example
  2. Click on first select
  3. Put "bank" in the search field
  4. See the "not found" message before the search field

image

Additional context
I think it is a bug because if you add " a" in the search text (just show 1 element and its right) and later remove the " a" you can see all elements without the message

image

image
@PabloPerezAguilo PabloPerezAguilo added the bug Something isn't working label Aug 2, 2020
@macjohnny macjohnny self-assigned this Aug 3, 2020
macjohnny added a commit that referenced this issue Aug 4, 2020
@macjohnny
fix: hide no entries found message when options don't change initially
f93d461 
fixes #245
macjohnny added a commit that referenced this issue Aug 4, 2020
@macjohnny
fix: hide no entries found message when options don't change initially
a614901 
fixes #245
@macjohnny macjohnny mentioned this issue Aug 4, 2020
Merged
macjohnny added a commit that referenced this issue Aug 4, 2020
@macjohnny
fix not found message (#247)
bc2e419 
* fix: hide no entries found message when options don't change initially

fixes #245

* fix: hide no entries found message when options don't change initially

fixes #245
@macjohnny macjohnny added this to the v3.0.2 milestone Aug 4, 2020
@macjohnny
Copy link
Member

@PabloPerezAguilo thanks for reporting this issue. a fixed version 3.0.2 will be released later today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@macjohnny macjohnny

Labels
bug Something isn't working
Projects
None yet
Milestone
v3.0.2
Development

Successfully merging a pull request may close this issue.

fix not found message bithost-gmbh/ngx-mat-select-search
2 participants
@macjohnny @PabloPerezAguilo