add option to clear input field on pressing escape #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macjohnny
requested changes
Jun 15, 2020
| @@ -385,6 +385,12 @@ export class MatSelectSearchComponent implements OnInit, OnDestroy, AfterViewIni | |||
| ) { | |||
| event.stopPropagation(); | |||
| } | |||
|
|
|||
| // Special case if click Escape, if input is empty, close the dropdown, if not, empty out the search field | |||
| if (event.keyCode === ESCAPE && this.value) { | |||
There was a problem hiding this comment.
this should be enabled only when a corresponding optional input is set, in order to keep the current behavior, e.g.
@Input() enableClearOnEscapePressed = false
There was a problem hiding this comment.
Okay i will change it :)
|
added the configuration |
macjohnny
changed the title
|
awesome, do you allready know by when it goes to an official release? |
|
@nischi it should be released later today |
|
excellent, thanks a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #231
If you search for something and press ESC it will empty the search input. if search input is empty and you press ESC it fall back to default behaviour