Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-tests.js #30

Closed
tomdavidson opened this issue May 19, 2017 · 4 comments
Closed

build-tests.js #30

tomdavidson opened this issue May 19, 2017 · 4 comments

Comments

@tomdavidson
Copy link

  • I'm submitting a ...
    [ ] bug report
    [ ] feature request
    [x] question about the decisions made in the repository
    [ ] question about how to use this project

  • Summary

Thank you for sharing this! Do you mind explaining the rationale and need for build-tests.js

bitjson added a commit that referenced this issue Jun 27, 2017
@bitjson
Copy link
Owner

bitjson commented Jun 27, 2017

Hey @tomdavidson – thanks for opening this issue!

I added a note with some additional explanation in: f78fa8a


Testing

By convention, tests in typescript-starter are co-located with the files they test. The project is configured to allow tests to be written in Typescript and your library to be imported as if it were being used by another project. (E.g. import { double, power } from 'typescript-starter'.) This makes tests both intuitive to write and easy to read as another form of documentation.

Note, tests are compiled and performed on the final builds in the standard Node.js runtime (rather than an alternative like ts-node) to ensure tests pass in that environment. If you are using ts-node in production, you can modify this project to skip test compilation.


Does that answer your question?

@tomdavidson
Copy link
Author

Thanks @bitjson . It does and I appreciate your response and the project's help getting me started with TS. I did end up deviating quite abit, including on the testing - https://gitlab.com/td7x/s6

@bitjson
Copy link
Owner

bitjson commented Jun 29, 2017

Hey @tomdavidson that looks like a fantastic project, thanks for sharing!

Mind if I link to your project from the readme? f0d349a

I've been hoping to add a section of projects using parts from this starter, and yours has some great examples of alternative configurations!

@tomdavidson
Copy link
Author

tomdavidson commented Jun 29, 2017 via email

bitjson added a commit that referenced this issue Sep 8, 2020
also add tooling for reviewing integration test results

fix #30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants