Add replicaset support #58
Conversation
|
@jehiah @mreiferson @ploxiln |
| - `dbuser`: db user to connect with | ||
| - `dbpass`: db password | ||
| - `autoreconnect` (optional): auto reconnect on interface errors | ||
| - `rs` (optional): replica set name (required when replica sets are used) | ||
| - `seed` (optional): seed list to connect to a replica set (required when replica sets are used) |
There was a problem hiding this comment.
It would be nice to either a) make this a more structured [(host, port)...] list, or at least ['host:port', ...] or switch this to code that handles mongo uri's and have ['mongo://host:port',...]. In either case since it's a list of spots to connect to, let's make it a list instead of a comma separated string.
|
@manover this looks like a very good way to structure the authentication/replica set discovery flow. nice work so far. |
| logging.info("Waiting for %d to become master", port) | ||
| time.sleep(5) | ||
|
|
||
| def setUp(self): |
There was a problem hiding this comment.
You might want to try using a setUpClass class method to do the expensive mongo setup instead of the setUp method. By using setUpClass your setup should only be run once for all of tests.
There was a problem hiding this comment.
Yeah, I could do that or even use a module-wide setup() function, the only problems are:
- It would still take a lot of time, even running once, so Travis would fail
- I would really hate to duplicate the existing structure used by other tests (with MongoTest as a super class)
but thanks for the tip
ghost
assigned
|
@ploxiln @jehiah @mreiferson Please review |
|
|
||
| def mongo_cmd(self, cmd, port=27018, res='"ok" : 1'): | ||
| pipe = subprocess.Popen("echo '%s' | mongo --port %d" % (cmd, port), shell=True, stdout=subprocess.PIPE) | ||
| repl = pipe.communicate()[0] |
There was a problem hiding this comment.
could be:
mongo_cli = subprocess.Popen(["mongo", "--port", str(port)], stdin=subprocess.PIPE, stdout=subprocess.PIPE)
reply, _ = mongo_cli.communicate(cmd)
which I arbitrarily consider to be more elegant :)
|
@manover changes look great. go ahead and squash this change. |
ReplicaSet support