Skip to content
This repository has been archived by the owner on Nov 5, 2019. It is now read-only.

Non-Blocking Connection and Timeout Support #59

Closed
wants to merge 2 commits into from

Conversation

bufferx
Copy link

@bufferx bufferx commented Apr 11, 2013

Issue
The Blocking IO Connection will causing that the tornado service can not respond new HTTP Request, when MongoDB server goes down(Error: no route to host).

New Feature
create Non-blocking connection to mongodb service, support for connection timeout and request timeout, when using tornado as the Async Backend

Zhang ZY added 2 commits April 11, 2013 20:11
* 1.2.2.dev:
  New Feature: Non-blocking connection to mongodb service, support for connection timeout and request timeout
@jehiah
Copy link
Member

jehiah commented Apr 12, 2013

@bufferx thanks for working on this. Can you rebase on bitly/master? some things have recently been added that conflict with this change set.

@bufferx
Copy link
Author

bufferx commented Apr 13, 2013

@jehiah I have rebase and re-pull-request right here. please check it, thanks.

@bufferx bufferx closed this Apr 16, 2013
@jehiah
Copy link
Member

jehiah commented Apr 16, 2013

Thanks for rebasing this @bufferx. I will take a look at the new pull request you opened and give comments on the code there.

FYI: there is no need to re-open new pull requests when making updates. Pull requests are designed to reflect the current state of a branch, so it's expected for you to push up new requests and change that branch during a code review before it get's merged. The general process we follow at bitly is to rebase and squash down to a single commit at the end of development before code is merged, but not before so it's easy to see changes as it's being worked on.

@bufferx
Copy link
Author

bufferx commented Apr 17, 2013

@jehiah thanks for your suggestion. I'm so sorry that I'm not familiar with the use of GitHub system.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants