This repository has been archived by the owner on Nov 5, 2019. It is now read-only.
Fix connection leaks caused by a stale job queue #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jehiah Sorry, another one, don't merge it yet, I wanna watch how it works |
|
If an error occurs during either authorization or RS handshake, the job queue might still contain unprocessed message(s). This fix works by flushing the queue, so that Connection._parse_response() would return connections to the pool in this case. |
| @@ -128,6 +128,8 @@ def _socket_close(self): | |||
| if callback: | |||
| callback(None, InterfaceError('connection closed')) | |||
| finally: | |||
| # Flush the job queue, ignore the callbacks, they've been already called | |||
| del self.__job_queue[:] | |||
There was a problem hiding this comment.
small style tweak, but can you just self.__job_queue = [] to clear it out instead of using del.
There was a problem hiding this comment.
well, here I wanted to make sure that the original list is emptied in case it's referenced from somewhere else, not sure it's relevant right now, but it's kind of a coding habit
|
@jehiah done |
jehiah
added a commit
that referenced
this pull request
Apr 25, 2013
Fix connection leaks caused by a stale job queue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another one