This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
Enable for use with GitHub enterprise #195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These changes look nice and minimal. I'm not the one who decides if this is merged, but I think there are two small steps you need to take before this is merged:
|
ruta-goomba
force-pushed
the
github-enterprise
branch
from
d15d6c8
to
059dcbf
Compare
By setting this to "force", certain providers, like Google, will interject an additional prompt on every new session. With other values, like "auto", this prompt is not forced upon the user.
The path should be provided as a file:// url with the full operating system path. An alias to where the directory is available as can be specified by appending a fragment (ie. "#/static/") at the end of the URL.
The default `error.html` uses `ProxyPrefix` but it isn't supplied in the context, causing it to error.
Go coding style says that acronyms should be all lower or all upper. Fix Url to URL.
Be consistent with Go coding style for acroynyms.
Be consistent with Go capitalization styling and use a single way of spelling this across the tree.
Google changed to developer console UI, updated walkthrough to match new UI.
adding enterprise github provider print the error stack trace point to my fork in oauthproxy.go addint pointers to ruta-goomba fork in mulitple files change api endpoint replace hard-coded github api endpoint with variables resetting fall through github urls to point to github.com fix malformed url remove pointers to fork files removing comment changes and cookie error output changes replace spacing changes
This reverts commit 059dcbf.
ruta-goomba
force-pushed
the
github-enterprise
branch
from
059dcbf
to
a5b111c
Compare
|
Closing this to sort out the interactive rebase. |
|
@ruta-goomba did you ever do the rebase? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request to resolve issue "Custom github url not supported #144"
I removed hard-coded github.com endpoints. With the proposed changes oauth2_proxy works with enterprise github if user sets validateURL (as well as loginURL and redeemURL) to github enterprise endpoint.