This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
add option/flag to specify config file in place of commandline options #20
+242
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Supporting config files is a great idea. I've really been happy with how we accomplished this in nsqd Would you be willing to try implementing something that here? |
|
i haven't authored anything in go yet, i'll take a poke and see if i can get it to work. |
|
@mreiferson i'm sure you were curious |
|
hah, sweet |
jehiah
force-pushed
the
config_support_20
branch
from
1c1e4b9
to
f18d1a2
Compare
jehiah
force-pushed
the
config_support_20
branch
from
f18d1a2
to
d4fe9a4
Compare
|
@neurogenesis this adds config files support. I'd love to know how it works out for you. |
jehiah
added a commit
that referenced
this pull request
Nov 10, 2014
add option/flag to specify config file in place of commandline options
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when running / managing several proxies, it might be handy to specify commandline options in a file and pass a file name as an argument instead of multiple commandline options.