This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
allow github enterprise endpoints with api uris not on root url #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jehiah Thanks for fixing the travis build, I almost forgot that this was the original bug I had intended to fix (Just updated from upstream). |
|
fixed in #269 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#144 Fixed the problem where you couldn't specific 'api.mydomain.com' for a github enterprise (ghe) installation, but the default ghe api endpoint is normally mydomain.com/api/$version (e.g. 'v3).
In the existing implementation, oauth2_proxy will incorrectly validate against the configured validation url without the configured uri, so:
mydomain.com/api/v3 becomes mydomain.com/user/emails
This pull requests honors the full configured url as a base path, so:
mydomain.com/api/v3 becomes mydomain.com/api/v3/user/emails
Additionally, I reduced the logging on success for validation so we don't printy the entire response body and just log that we got a 200 (like we do for all other requests where we were able to successful unmarshal responses).