This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
Add ProviderName field; use in sign_in template #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
++ let's start with the PR to add MyUSA as a provider. I think i'd like to tackle project & service rename separately and see what other providers make sense to land up front (I know there is an ongoing fork from @balshor to support LinkedIn that I'd love to land using this scheme) |
jehiah
added a commit
that referenced
this pull request
Mar 31, 2015
Add ProviderName field; use in sign_in template
|
I'd love to get LinkedIn support on to this scheme, too! I'll have another hackday in mid-April that I can use to switch over, if nobody else has added LinkedIn support by then. :) |
|
awesome @balshor I look forward to that PR! |
|
Cool, I'll proceed with the MyUSA+Docs PR, then. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the third step towards genericizing the google_auth_proxy to support OAuth2 providers other than Google as discussed in #65. Injecting the
ProviderNameinto the template seems the most expedient way to reuse the defaultsign_in.htmltemplate.Also, @jehiah, I was wondering: If you want, I can follow this PR with a PR to rename the service to
oauth2_proxy. Otherwise, I'll go ahead and send a PR to add the MyUSA provider (plus README updates on how to add a new provider).