This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
Refactor pass_access_token changes from #80 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 7, 2015 05:53
Moves the check from NewOauthProxy() to Options.Validate() and adds a test.
Extracts buildCookieValue() and parseCookieValue() from OauthProxy.ServeHTTP() and adds tests for both.
mbland
force-pushed
the
access-token-refactor
branch
from
75c151c
to
3595fdb
Compare
mbland
changed the title
mbland
force-pushed
the
access-token-refactor
branch
from
3595fdb
to
83ad43a
Compare
|
@jehiah: Ping... Just wondering if this is on your radar, or if there's any objections. Thanks! And on a side note, what do you think about lowercasing all email addresses for comparison? (Just hit a case-sensitivity issue.) Happy to send on another PR to do that, if you're not sick of me by now. :-) |
|
oops sorry. I saw this previously but it then slipped my mind. this LGTM. (and yes, I'm totally cool for case insensitive email comparisons) |
jehiah
added a commit
that referenced
this pull request
Apr 7, 2015
Refactor pass_access_token changes from #80
|
Cool, thanks! Hacking on it now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to better encapsulate the changes from #80 and adds some more tests.