Align nullness with other SDKs #63
Conversation
Methods that return nullable types were returning placeholder values. This was not aligned with our other mobile SDKs. This also allows simplifying the glue layer. PFL-69
| await loadSourceConfig(Sources.sintel); | ||
| await callPlayer((player) async { | ||
| final subtitles = await player.availableSubtitles; | ||
| subtitleToSelect = subtitles.last.id; | ||
| subtitleToSelect = subtitles?.last.id; |
There was a problem hiding this comment.
do we also need the nullcheck on last? (subtitles?.last?.id)
or is this handled inside dart? 🤔
There was a problem hiding this comment.
Contrary to Kotlin, in a?.b.c, .c will only be called is a is not null. It would be equivalent to a?(.b.c) if such syntax was allowed.
| Future<SubtitleTrack> get subtitle async => | ||
| await _invokeObjectMethod<SubtitleTrack>( | ||
| Future<SubtitleTrack?> get subtitle async => | ||
| _invokeObjectMethod<SubtitleTrack>( |
There was a problem hiding this comment.
why was the await removed?
There was a problem hiding this comment.
I don't believe it has any effect 🤔
What do you expect it to do?
| /// `null` if there are no active [Source]. | ||
| Future<List<SubtitleTrack>?> get availableSubtitles; |
There was a problem hiding this comment.
This was already aligned with the iOS and Android SDK. Both SDKs return an empty list. Why did you make the list nullable?
| /// `null` if there is no currently selected [SubtitleTrack]. | ||
| Future<SubtitleTrack?> get subtitle; |
There was a problem hiding this comment.
This was aligned with iOS where we return the off-item in case there is no subtitle selected. I see that on Android this returns null in this case (which feels more right to me), so fine for me to align this with Android instead of iOS 👍 (no action required)
android/src/main/kotlin/com/bitmovin/player/flutter/json/JsonMethodHandler.kt
Show resolved
Hide resolved
Problem (PFL-69)
Methods that return nullable types on our native SDK were returning
placeholder values. This was not aligned with our other mobile
SDKs.
Changes
Return null instead. This also allows simplifying the glue layer.
Checklist
CHANGELOGentry if applicable