Remaining time in ad break duration

[saravanans-github]

Description

added support for a new adMessagePlaceholder - adBreakRemainingTime. This placeholder displays the remaining time in an ad break.

Checklist (for PR submitter and reviewers)

• CHANGELOG entry

[dweinber]

This could be simplified like this (unless I'm missing something):

Suggested change

	let scheduledAds = player.ads.getActiveAdBreak().ads;
	let durations: number[] = [];
	let activeAd = player.ads.getActiveAd();
	let indexOfActiveAd: number = 0;
	for(let i=0; i<scheduledAds.length; i++) {
	let iAd = scheduledAds[i];
	if(iAd.isLinear) {
	durations.push((iAd as LinearAd).duration);
	if(iAd.id == activeAd.id) {
	indexOfActiveAd = i;
	}
	}
	}
	// Compute duration of ads to be played (incl active ad)
	let duration = durations.slice(indexOfActiveAd).reduce((prev, current) => prev + current, 0);
	const duration = player.ads.getActiveAdBreak().ads
	.map(ad => ad.duration)
	.reduce((prev, current) => prev + current, 0);

[saravanans-github]

thanks @dweinber . I've simplified the code per your guidance.

[felix-hoc]

@saravanans-github please do not alter the PR Checklist - it should stay as-is, because it contains the formal PR requirements. Your changes should be described separately.

Please re-add it, and add a Changelog entry :)

[saravanans-github]

thank you @felix-hoc; I've made the change to the PR checklist. Kindly see if that suffices please?

[felix-hoc]

@saravanans-github the CI is still failing. Also, your branch is quite a bit behind main, please pull it in and resolve any conflicts :)

Also, you're still missing the changelog entry

[felix-hoc]

The code looks good, just some nit picks from my side.

Please ensure:

• your branch is up-to-date with main
• there are no conflicts
• the CI passes and the code is properly formatted (your IDE should highlight formatting errors that are identified by TSLint and offer to auto-fix them)
• you add a changelog entry

[felix-hoc]

nit: this could be simplified to use a single reduce:

Suggested change

	const duration = player.ads.getActiveAdBreak().ads.slice(indexOfActiveAd)
	.map(ad => {
	if(ad.isLinear) {
	return (ad as LinearAd).duration
	} else {
	return 0
	}
	})
	.reduce((prev, current) => prev + current, 0);
	const duration = player.ads.getActiveAdBreak().ads
	.slice(indexOfActiveAd)
	.reduce((total, ad) => total + (ad.isLinear ? (ad as LinearAd).duration : 0), 0);

[felix-hoc]

typo

Suggested change

	} else if (formatString.indexOf('adBreakRemainingTime') > -1) { // To display the remaining time in the ad bread as opposed to in the ad
	} else if (formatString.indexOf('adBreakRemainingTime') > -1) { // To display the remaining time in the ad break as opposed to in the ad

[felix-hoc]

Very nice! 😃