fix: prevent event loop on preroll end #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the deferred start logic required to pass yospace validation for 3.4.0 upgrade. Their new sdk handles this case internally.
martinstark
force-pushed
the
fix-infinite-break-finished
branch
from
84104e8
to
7d7a164
Compare
Merged
dweinber
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the deferred start logic required to pass yospace validation for the earlier 3.4.0 upgrade. Their new sdk handles this case internally.
Validation reference: https://yospace.atlassian.net/servicedesk/customer/portal/8/YOSD-25382