Add a note about the secret type bug #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anguslees
approved these changes
Dec 18, 2018
bors bot
added a commit
that referenced
this pull request
Dec 18, 2018
135: Add a note about the secret type bug r=anguslees a=johnraz I just got bitten by the bug in #86 and #92 and lost quite a bit of time finding out what was happening. This will hopefully help other people figure it out faster until the proper fix is released. Co-authored-by: Jonathan Liuti <liuti.john@gmail.com>
Build succeeded |
|
@johnraz @anguslees quick question: the changelog from the releases page says that the per-key encryption was introduced in 0.7.0 and in 0.7.0, so shouldn't 0.6.0 enough to circumvent this bug? Or am I missing something? Thanks :) |
|
@victornoel I can’t remember if it tested 0.6.0 or not but I guess you could quickly do it and find out ;-) |
|
@johnraz @anguslees I can confirm that it works with 0.6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just got bitten by the bug in #86 and #92 and lost quite a bit of time finding out what was happening.
This will hopefully help other people figure it out faster until the proper fix is released.