Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial import from stable repo #484

Merged
merged 10 commits into from
Dec 9, 2020

Conversation

davidkarlsen
Copy link
Contributor

@davidkarlsen davidkarlsen commented Dec 8, 2020

Signed-off-by: David J. M. Karlsen david@davidkarlsen.com


This change is Reviewable

Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>
Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>
Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>
Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>
Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>
@mkmik
Copy link
Collaborator

mkmik commented Dec 8, 2020

Will merge once chart linter us happy

@davidkarlsen
Copy link
Contributor Author

@mkmik Please see #389 (comment)

@mkmik
Copy link
Collaborator

mkmik commented Dec 8, 2020

Perhaps it's better to just migrate it here without any change and disable the linter for now until we upgrade the CRD in another PR?

Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>
@davidkarlsen
Copy link
Contributor Author

davidkarlsen commented Dec 8, 2020

sgtm.
It passes now.
Do you want to sign the charts or not and I can clean up that?
Also - you might want to tune the trigger for chart-release job since you have a mono-ish repo.
lastly, you will want some form of email in https://github.com/bitnami-labs/sealed-secrets/pull/484/files#diff-52eed08a93a65ba2fe912f5c57cedc287195a5fce5872fbaabb7dd773537e6a5R11

@fliphess
Copy link

fliphess commented Dec 9, 2020

@davidkarlsen Did you import the history from the stable chart?

@davidkarlsen
Copy link
Contributor Author

davidkarlsen commented Dec 9, 2020

@fliphess yes, this is https://github.com/helm/charts/tree/master/stable/sealed-secrets minus the deprecation plus CI

@mkmik
Copy link
Collaborator

mkmik commented Dec 9, 2020

Is this ready to be merged?

@davidkarlsen
Copy link
Contributor Author

@mkmik It would be good if you could respond to #484 (comment) and the last polishing can be done.

@mkmik
Copy link
Collaborator

mkmik commented Dec 9, 2020

@davidkarlsen Thank you so much for helping out! will merge as soon as the CI is happy

@davidkarlsen
Copy link
Contributor Author

squash it so we get a nice history, the rest can be found in the PR anyways.

@mkmik mkmik merged commit d2f5be9 into bitnami-labs:master Dec 9, 2020
@davidkarlsen davidkarlsen deleted the issue389-addci branch December 9, 2020 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants