Loki: duplicate ServiceAccounts rendered

[NickLarsenNZ]

Name and Version

bitnami/loki 2.4.5

What steps will reproduce the bug?

1. Add the bitnami helm repo

  helm repo add bitnami https://charts.bitnami.com/bitnami
  helm repo update

2. Run

  helm template loki bitnami/grafana-loki \
     --version=v2.4.5 \
     --set serviceAccount.create=true

Are you using any custom parameters or values?

Only --set serviceAccount.create=true

What is the expected behavior?

I would expect the Promtail ServiceAccount to have a different name, unique to any others

What do you see instead?

Notice two ServiceAccounts with the same name

---
# Source: grafana-loki/templates/promtail/service-account.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
  name: loki-grafana-loki
  namespace: "default"
  labels:
    app.kubernetes.io/name: grafana-loki
    helm.sh/chart: grafana-loki-2.4.5
    app.kubernetes.io/instance: loki
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/part-of: grafana-loki
    app.kubernetes.io/component: loki
  annotations:
automountServiceAccountToken: true
---
# Source: grafana-loki/templates/service-account.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
  name: loki-grafana-loki
  namespace: "default"
  labels:
    app.kubernetes.io/name: grafana-loki
    helm.sh/chart: grafana-loki-2.4.5
    app.kubernetes.io/instance: loki
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/part-of: grafana-loki
    app.kubernetes.io/component: loki
  annotations:
automountServiceAccountToken: true
---

Additional information

This is probably ok when using Helm on its own, but it breaks when using the rendered template as a base for Kustomize, which gives the error: may not add resource with an already registered id: ~G_v1_ServiceAccount|default|loki-grafana-loki

Error: accumulating resources: accumulation err='accumulating resources from 'helm-template.yml': may not add resource with an already registered id: ~G_v1_ServiceAccount|default|loki-grafana-loki': got file 'helm-template.yml', but '/tmp/loki/helm-template.yml' must be a directory to be a root

[carrodher]

Thanks for reporting this issue. Would you like to contribute by creating a PR to solve the issue? The Bitnami team will be happy to review it and provide feedback. Here you can find the contributing guidelines.

[cleverhu]

I create a request for this,PTAL.

[carrodher]

Thanks for the PR! The team will take a look and provide feedback

[NickLarsenNZ]

Thanks @cleverhu, I didn't manage to get to this in time :)