Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/grafana-loki] Fix duplicate ServiceAccounts rendered #13242

Merged
merged 2 commits into from
Oct 31, 2022
Merged

[bitnami/grafana-loki] Fix duplicate ServiceAccounts rendered #13242

merged 2 commits into from
Oct 31, 2022

Conversation

cleverhu
Copy link
Contributor

Description of the change

Fix duplicate ServiceAccounts rendered.

Benefits

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

fix duplicate ServiceAccounts rendered
7ac0471 
Signed-off-by: cleverhu <shouping.hu@daocloud.io>
@github-actions github-actions bot added the triage Triage is needed label Oct 29, 2022
@bitnami-bot bitnami-bot requested a review from carrodher October 29, 2022 12:10
@carrodher carrodher added the verify Execute verification workflow for these changes label Oct 30, 2022
@bitnami-bot bitnami-bot removed the request for review from carrodher October 30, 2022 07:48
@bitnami-bot bitnami-bot requested a review from fmulero October 30, 2022 07:48
Merge branch 'main' into fix-duplicate-serviceaccount
2797878 
Signed-off-by: Carlos Rodríguez Hernández <carlosrh@vmware.com>
@github-actions github-actions bot added in-progress and removed triage Triage is needed labels Oct 30, 2022
fmulero
fmulero approved these changes Oct 31, 2022
View reviewed changes
Copy link
Collaborator

@fmulero fmulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @cleverhu!. Thank you so much. LGTM

@fmulero fmulero merged commit 1c9785f into bitnami:main Oct 31, 2022
fire-ant pushed a commit to fire-ant/charts that referenced this pull request Nov 6, 2022
fix duplicate ServiceAccounts rendered (bitnami#13242)
eaa556f 
Signed-off-by: cleverhu <shouping.hu@daocloud.io>

Signed-off-by: cleverhu <shouping.hu@daocloud.io>
Signed-off-by: Carlos Rodríguez Hernández <carlosrh@vmware.com>
Co-authored-by: Carlos Rodríguez Hernández <carlosrh@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmulero fmulero fmulero approved these changes

Assignees

@fmulero fmulero

Labels
grafana-loki solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loki: duplicate ServiceAccounts rendered
3 participants
@cleverhu @fmulero @carrodher