Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/zookeeper] Make Zookeeper DefaultMode YAML 1.2 Compliant #21081

Merged
merged 2 commits into from
Dec 11, 2023
Merged

[bitnami/zookeeper] Make Zookeeper DefaultMode YAML 1.2 Compliant #21081

merged 2 commits into from
Dec 11, 2023

Commits on Dec 4, 2023

  1. Make Zookeeper DefaultMode YAML 1.2 Compliant 

    With the YAML 1.2 spec octals must be prefixed with `0o` and not `0`.
Parsers implementing the latest spec run into issues. See discussion
here: dtolnay/serde-yaml#225

This commit makes the Zookeeper script mount compliant with YAML 1.2.

Signed-off-by: Marc Schreiber <info@schrieveslaach.de>
    @schrieveslaach
    schrieveslaach committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    246e1fc View commit details
    Browse the repository at this point in the history

  2. Use Decimal Notation for defaultMode 

    In order to be still YAML 1.1 compliant and to be YAML 1.2 compliant,
this commit changes the defaultMode to the decimal value 493. This seems
to be done in other places as well (see modes of TLS secrets).

Signed-off-by: Marc Schreiber <info@schrieveslaach.de>
    @schrieveslaach
    schrieveslaach committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    1a026ec View commit details
    Browse the repository at this point in the history