-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/thanos] Sync prometheus alerting rules with upstream #23381
Conversation
89935a3
to
06c7b48
Compare
*/ -}} | ||
{{- if and .Values.metrics.enabled (or .Values.metrics.prometheusRule.default.create .Values.metrics.prometheusRule.default.replicate ) }} | ||
apiVersion: monitoring.coreos.com/v1 | ||
kind: PrometheusRule | ||
metadata: | ||
name: {{ template "common.names.fullname" . }}-replicate | ||
name: thanos-bucket-replicate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name comes from the upstream - let me know if you think script should generated it as {{ template "common.names.fullname" . }}-<suffix>
We would need to hardcode suffixes then, in order to accommodate things like -ruler
, -store-gateway
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Sorry for the long delay.
Yes, the name of the all kubernetes objects created by the chart should keep the naming. This would allow to have multiple instances with different names, and be coherent with how we handle the naming across all our charts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kept PrometheusRule
as it is. @rafariossaa let me know if there is anything else.
abedb26
to
35104bf
Compare
Resolved conflicts due to changes in https://github.com/bitnami/charts/pull/22687/files |
15d2ae4
to
f86dae6
Compare
Sorry for the inconvenience, there was a new minor version of this chart that requires a rebase from |
Signed-off-by: antonblr <44246099+antonblr@users.noreply.github.com>
Signed-off-by: antonblr <44246099+antonblr@users.noreply.github.com>
Signed-off-by: antonblr <44246099+antonblr@users.noreply.github.com>
Signed-off-by: antonblr <44246099+antonblr@users.noreply.github.com>
Signed-off-by: antonblr <44246099+antonblr@users.noreply.github.com>
Signed-off-by: antonblr <44246099+antonblr@users.noreply.github.com>
d2a4264
to
d9b0501
Compare
Hi @carrodher, should we sync-up somehow on when you're ready to merge it (if there is no outstanding questions/concerns) and I'll do the final bump in the Chrat.yaml. Otherwise I feel like in a never ending race 😄 due to continuous changes in it. Thank you! |
Signed-off-by: Anton <44246099+antonblr@users.noreply.github.com>
Signed-off-by: Anton <44246099+antonblr@users.noreply.github.com>
*/ -}} | ||
{{- if and .Values.metrics.enabled (or .Values.metrics.prometheusRule.default.create .Values.metrics.prometheusRule.default.replicate ) }} | ||
apiVersion: monitoring.coreos.com/v1 | ||
kind: PrometheusRule | ||
metadata: | ||
name: {{ template "common.names.fullname" . }}-replicate | ||
name: thanos-bucket-replicate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Sorry for the long delay.
Yes, the name of the all kubernetes objects created by the chart should keep the naming. This would allow to have multiple instances with different names, and be coherent with how we handle the naming across all our charts.
Signed-off-by: Anton <44246099+antonblr@users.noreply.github.com>
Signed-off-by: Anton <44246099+antonblr@users.noreply.github.com>
Signed-off-by: Anton <44246099+antonblr@users.noreply.github.com>
Description of the change
Inspired by prometheus-community/kube-prometheus-stack/hack.
This change adds a script to sync-up Thanos chart prometheus alerting rules with upstream https://github.com/thanos-io/thanos/tree/main/mixin library and updates existing rules with the generated ones.
In particular the sync resulted in the following changes:
ThanosReceiveTrafficBelowThreshold
(see #5824)ThanosReceiveLimitsConfigReloadFailure
(see #6466ThanosReceiveLimitsHighMetaMonitoringQueriesFailureRate
(see #6466)ThanosReceiveTenantLimitedByHeadSeries
(see #6467)The remaining diff are mostly formatting changes.
Benefits
Automatically generates up to date rules.
Possible drawbacks
Some python knowledge may be needed in order to add new functionality to the script and / or update the existing one.
Applicable issues
N/A
Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm