Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/apache] Update templates to have conditionals for HPA #29489

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

amoon78
Copy link
Contributor

@amoon78 amoon78 commented Sep 17, 2024

Description of the change

Benefits

  • For deployment template change, from kubernetes.io -

When an HPA is enabled, it is recommended that the value of spec.replicas of the Deployment and / or StatefulSet be removed from their manifest(s). If this isn't done, any time a change to that object is applied, for example via kubectl apply -f deployment.yaml, this will instruct Kubernetes to scale the current number of Pods to the value of the spec.replicas key. This may not be desired and could be troublesome when an HPA is active.

  • For HPA template change, HPA controller won't try to reorder continuously

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Signed-off-by: Ann Moon <ann.moon2867@gmail.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Sep 18, 2024
@github-actions github-actions bot removed the triage Triage is needed label Sep 18, 2024
@github-actions github-actions bot removed the request for review from carrodher September 18, 2024 07:01
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Copy link
Contributor

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! LGTM

@juan131 juan131 merged commit 6882c22 into bitnami:main Sep 18, 2024
10 checks passed
jotamartos pushed a commit that referenced this pull request Sep 19, 2024
Signed-off-by: Jota Martos <jotamartos@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apache solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HPA is not working properly due to replicas set
4 participants