Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/kube-prometheus] Add ingress for thanos sidecar #5345

Merged
merged 7 commits into from
Feb 1, 2021
Merged

[bitnami/kube-prometheus] Add ingress for thanos sidecar #5345

merged 7 commits into from
Feb 1, 2021

Conversation

Placidina
Copy link
Contributor

@Placidina Placidina commented Jan 29, 2021 •
edited
Loading

Description of the change

Add support to ingress controller for thanos sidecar.

Benefits

Using grpc reverse proxy to access the thanos sidecar from outside cluster

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [bitnami/chart])

⚠️ Keep in mind that if you want to make changes to the kubeapps chart, please implement them in the kubeapps repository. This is only a synchronized mirror.

@Placidina Placidina mentioned this pull request Jan 30, 2021
Closed
carrodher
carrodher approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member

@carrodher carrodher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution. I am going to launch this PR in our internal CI/CD system, if everything works fine the PR will be autoclosed

@bitnami-bot
[bitnami/kube-prometheus] Update components versions
be52eac 
Signed-off-by: Bitnami Containers <containers@bitnami.com>
@bitnami-bot
Copy link
Contributor

I have just updated the bitnami images with the latest known immutable tags:

  • "docker.io/bitnami/prometheus-operator:0.45.0-debian-10-r10"
  • "docker.io/bitnami/alertmanager:0.21.0-debian-10-r209"
  • "docker.io/bitnami/prometheus:2.24.1-debian-10-r10"
  • "docker.io/bitnami/thanos:0.17.2-scratch-r2"

@bitnami-bot bitnami-bot merged commit 22543f5 into bitnami:master Feb 1, 2021
@Placidina Placidina deleted the kube-prometheus-thanos-ingress branch February 1, 2021 16:59
Cellebyte pushed a commit to Cellebyte/charts that referenced this pull request Feb 12, 2021
@Placidina @carrodher
@bitnami-bot @Cellebyte
[bitnami/kube-prometheus] Add ingress for thanos sidecar (bitnami#5345)
e8982f6 
* [bitnami/kube-prometheus] Add thanos sidecar ingress

* [bitnami/kube-prometheus] Update chart version

* [bitnami/kube-prometheus] Fix bump chart version

* [bitnami/kube-prometheus] Update components versions

Signed-off-by: Bitnami Containers <containers@bitnami.com>

Co-authored-by: Carlos Rodríguez Hernández <carlosrh@vmware.com>
Co-authored-by: Bitnami Containers <containers@bitnami.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carrodher carrodher carrodher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Placidina @bitnami-bot @carrodher