Adding skip-deploy bitops configuration option #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code looks good. |
arm4b
requested changes
Nov 7, 2022
There was a problem hiding this comment.
https://github.com/bitops-plugins/cloudformation/blob/main/README.md and https://bitops.sh/tool-configuration/configuration-cloudformation/ need an extra update to keep the documentation in sync.
arm4b
changed the title
arm4b
reviewed
Nov 9, 2022
README.md
Outdated
| * **BitOps Property:** `skip-deploy` | ||
| * **Environment Variable:** `CFN_SKIP_DEPLOY` | ||
| * **default:** `none` | ||
| * **Required:** `false` |
There was a problem hiding this comment.
I see that other config options in the README mention Required only when it's true which makes sense to me to avoid overloading the docs.
Let's follow the same consistent way for skip-deploy too:
Suggested change
| * **Required:** `false` |
PhillypHenning
changed the title
|
Updated bitops.sh doc |
arm4b
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.