Fix issue 198 - "[escape]" must not type "escape" #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@justinbmeyer can this PR be merged? |
1 similar comment
|
@justinbmeyer can this PR be merged? |
|
Looks good. Thanks. Anyway you could add a test?
…On Sat, Nov 23, 2024 at 7:20 PM Michael Voříšek ***@***.***> wrote:
@justinbmeyer <https://github.com/justinbmeyer> can this PR be merged?
—
Reply to this email directly, view it on GitHub
<#199 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAATGCVMZLLUDVVLKPFQKGL2CESWDAVCNFSM6AAAAABJQLWSIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJVG4ZTGMZQGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #198
this PR fixes
window.syn.type(el, '[escape]')previously
"escape"text was appended to the input, newly only the escape key is pressed, but no text is typed