Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

[Ready for testing] Fix validation to look for any wordlist with a valid checksum #36

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dabura667
Copy link
Contributor

Fixes https://github.com/bitpay/copay/issues/3211 and will allow for wordlists that have common words in different positions.

This fix will be especially necessary if zh_CN and zh_TW wordlists will both be supported someday, as they have many words in common.

for reference, here are 3 mnemonics only using the common words between English and French. This will help in testing.

English check OK:
abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon angle
French check OK:
abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon brave
both check OK:
abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon amateur double

@maraoz
Copy link
Contributor

maraoz commented Sep 22, 2015

Interesting find!

@dabura667 dabura667 changed the title Fix validation to look for any wordlist with a valid checksum [Ready for testing] Fix validation to look for any wordlist with a valid checksum Sep 22, 2015
@dabura667
Copy link
Contributor Author

Ready for testing / merge if all is fine.

@dabura667
Copy link
Contributor Author

bump

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Phrases using common words between wordlists will fail unless passing lower index in Mnemonic.Words
2 participants