-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bitcore-Node] Standardize EVM Traces #3490
Conversation
@@ -43,7 +43,7 @@ export interface ErigonTraceResponse { | |||
type: 'reward' | 'call' | 'delegatecall' | 'create'; | |||
} | |||
|
|||
export interface ClassifiedTrace extends ErigonTraceResponse { | |||
export interface ErigonTxTrace extends ErigonTraceResponse { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small note on this change: I renamed ClassifiedTrace to ErigonTxTrace but then at another spot I define a new type called ClassifiedTrace and that one represents the standard Geth class with which to Erigon now conforms.
Closing since these changes are very out of date and will be managed a different way with new chain additions. |
This PR standardizes the way we record transaction trace data in Bitcore DB. Instead of handling it two ways (seperate Erigon and Geth classes) we transform the Erigon traces to be like Geth.
There are three parts to this:
internal
for Erigon andcalls
for Geth)