fix: dbt profile loading (#117)

* Fix: dbt profile loading * Remove test from load_credentials
bitpicky · Mar 7, 2021 · acf19ee · acf19ee
1 parent c6b70e5
commit acf19ee
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 36 deletions.
diff --git a/dbt_sugar/core/task/doc.py b/dbt_sugar/core/task/doc.py
@@ -35,25 +35,14 @@ def __init__(self, flags: FlagParser, dbt_profile: DbtProfile, config: DbtSugarC
         self._dbt_profile = dbt_profile
         self._sugar_config = config
 
-    # FIXME: Ask Virginia why this is here, I don't think it's needed since we already read the
-    # profile in main.py
-    def load_dbt_credentials(self) -> Dict[str, str]:
-        """Method to load the DBT profile credentials."""
-        self._dbt_profile.read_profile()
-        dbt_credentials = self._dbt_profile.profile
-        if not dbt_credentials:
-            logger.info("Not able to locate DBT profile.")
-            exit(1)
-        return dbt_credentials
-
     def run(self) -> int:
         """Main script to run the command doc"""
         columns_sql = []
 
         model = self._flags.model
         schema = self._dbt_profile.profile.get("target_schema", "")
 
-        dbt_credentials = self.load_dbt_credentials()
+        dbt_credentials = self._dbt_profile.profile
         connector = DB_CONNECTORS.get(dbt_credentials.get("type", ""))
         if not connector:
             logger.error("The type of connector doesn't exists.")

diff --git a/tests/doc_task_test.py b/tests/doc_task_test.py
@@ -16,30 +16,6 @@ def __init_descriptions(params=None, dbt_profile=None, config=None):
     return doc_task
 
 
-def test_load_dbt_credentials():
-    class MockFlagParser:
-        schema = ""
-
-    profile = DbtProfile(
-        flags=MockFlagParser,
-        profile_name="dbt_sugar_test",
-        target_name="snowflake",
-        profiles_dir=Path(FIXTURE_DIR),
-    )
-    doc_task = __init_descriptions(None, profile)
-    credentials = doc_task.load_dbt_credentials()
-    assert credentials == {
-        "type": "snowflake",
-        "account": "dummy_account",
-        "user": "dummy_user",
-        "password": "dummy_password",
-        "database": "dummy_database",
-        "target_schema": "dummy_target_schema",
-        "role": "dummy_role",
-        "warehouse": "dummy_warehouse",
-    }
-
-
 @pytest.mark.parametrize(
     "column, result",
     [