Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out a way to let users add complex tests #133

Open
bastienboutonnet opened this issue Mar 8, 2021 · 1 comment
Open

Figure out a way to let users add complex tests #133

bastienboutonnet opened this issue Mar 8, 2021 · 1 comment

Comments

@bastienboutonnet
Copy link
Member

@virvirlopez we forgot to test subprocess and I also have some questions regarding the user flow and how we let people add tests via the CLI (especially for more complex tests which take several arguments).

@bastienboutonnet bastienboutonnet added this to the Toxe - Honey Island milestone Mar 8, 2021
@bastienboutonnet bastienboutonnet changed the title Test/discus the test running and addition via subprocess Test/discuss the test running and addition via subprocess Mar 8, 2021
@bastienboutonnet
Copy link
Member Author

I was just thinking this morning that for complex tests (i.e. ones with arguments which could end up being just about anything we may want to pop an editor like vim or nano to allow the users to enter the part of the yaml they would otherwise write in the schema file.

We would then add it to the schema yaml, call dbt for test and validation and remove it if it doesn't work (just like we do now).

I think the easiest way I know to pop an editor for multiline input would be to use click.edit which will take care of reading the editor chosen in the user's env and fall back to something if not: https://click.palletsprojects.com/en/7.x/utils/#launching-editors.

We should follow up the subprocess PR (#108 ) shortly with a PR that allows this and work on the user experience

@bastienboutonnet bastienboutonnet changed the title Test/discuss the test running and addition via subprocess Figure out a way to let users add complex tests Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant