feat: dbt test by subprocess #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #108 +/- ##
==========================================
- Coverage 84.71% 84.27% -0.44%
==========================================
Files 17 17
Lines 811 833 +22
==========================================
+ Hits 687 702 +15
- Misses 124 131 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…-sugar into feat/dbt_test_by_subprocess
There was a problem hiding this comment.
Really awesome that we can do this! I have a few very small suggestions and then we should be able to merge it.
I'll be nice to test it with some non-built in tests when we merged (we might have to add some packages in the toy dbt project.
Also, we're going to have to require dbt to be in the package's main requirements.
You can add it to the requirements by doing the following:
poetry add dbt and it will add the entry in the pyproject.toml if you're not sure let me know we can look together.
Finally if you can reference the issue it closes and write a news fragment for the changeling that would be super awesome.
virvirlopez
force-pushed
the
feat/dbt_test_by_subprocess
branch
from
168cd5b to
76800da
Compare
virvirlopez
force-pushed
the
feat/dbt_test_by_subprocess
branch
from
6798e97 to
4fe0737
Compare
* feat: implement test and tags deactivation * Add test and tag skipping to CLI + update tests * Fix: test with argparse (#102) * implement config overriding from cli args for tests and tags * keep schema.yml undocumented * remove extra description entry commited by mistake * add news fragment Co-authored-by: Virginia Lopez-Gil <vlopezgil@tripactions.com> Co-authored-by: virvirlopez <virbyte@gmail.com>
Bumps [pydantic](https://github.com/samuelcolvin/pydantic) from 1.7.3 to 1.8. - [Release notes](https://github.com/samuelcolvin/pydantic/releases) - [Changelog](https://github.com/samuelcolvin/pydantic/blob/master/HISTORY.md) - [Commits](pydantic/pydantic@v1.7.3...v1.8) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [rich](https://github.com/willmcgugan/rich) from 9.10.0 to 9.12.3. - [Release notes](https://github.com/willmcgugan/rich/releases) - [Changelog](https://github.com/willmcgugan/rich/blob/master/CHANGELOG.md) - [Commits](Textualize/rich@v9.10.0...v9.12.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [pydantic](https://github.com/samuelcolvin/pydantic) from 1.8 to 1.8.1. - [Release notes](https://github.com/samuelcolvin/pydantic/releases) - [Changelog](https://github.com/samuelcolvin/pydantic/blob/master/HISTORY.md) - [Commits](pydantic/pydantic@v1.8...v1.8.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
* Fix: test with argparse (#102) * implement config overriding from cli args for tests and tags * keep schema.yml undocumented * give an empty default value to schema in flags * refactor calls to DbtProfile to take flags * add FIXME/question on doc for dbt credentials reading * rename flag_dict to flag_override_dict to be more explicit * update tests * remove extra description field in schema.yml Co-authored-by: virvirlopez <virbyte@gmail.com>
…-sugar into feat/dbt_test_by_subprocess
added 2 commits
March 13, 2021 14:10
…-sugar into feat/dbt_test_by_subprocess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding the logic of running the tests from DBT. We are using subprocess to run directly the test from DBT and then parse the response.
How was the change tested
Ran it in local.
Ticket
Closes #65
Checklist
(Ideally, all boxes are checked by the time we merged the PR, if you don't know how to do any of these don't hesitate to say so in the PR and we'll help you out.)